Skip to content

Support BSON uint64 de/serialization #4590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

codenut
Copy link
Contributor

@codenut codenut commented Jan 9, 2025

This implements support for BSON uint64 de/serialization.

#4535


Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for this kind of bug). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
  • Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't 0x11 a timestamp and not just a uint64 number? It may be the same on the wire, but maybe the documentation should mention that we do not parse timestamps into anything date-related.

Also, please check https://github.com/nlohmann/json/pull/4590/checks?check_run_id=35367015620 on how to sign-off your commits.

@nlohmann nlohmann added the aspect: binary formats BSON, CBOR, MessagePack, UBJSON label Jan 9, 2025
@github-actions github-actions bot added L and removed M labels Jan 9, 2025
@github-actions github-actions bot added M and removed L labels Jan 9, 2025
Signed-off-by: Michael Valladolid <mikevalladolid@gmail.com>
@codenut
Copy link
Contributor Author

codenut commented Jan 9, 2025

Isn't 0x11 a timestamp and not just a uint64 number? It may be the same on the wire, but maybe the documentation should mention that we do not parse timestamps into anything date-related.

Also, please check https://github.com/nlohmann/json/pull/4590/checks?check_run_id=35367015620 on how to sign-off your commits.

Please if the commit Treat 0x11 as uint64 and not timestamp specific is aligned with your suggestion.

@coveralls
Copy link

coveralls commented Jan 9, 2025

Coverage Status

coverage: 99.639%. remained the same
when pulling f13c4ae on codenut:develop
into 1809b3d on nlohmann:develop.

Signed-off-by: Michael Valladolid <mikevalladolid@gmail.com>
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.4 milestone Jan 10, 2025
@nlohmann nlohmann merged commit 2d42229 into nlohmann:develop Jan 10, 2025
125 checks passed
@nlohmann
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants