-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Support BSON uint64 de/serialization #4590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't 0x11
a timestamp and not just a uint64
number? It may be the same on the wire, but maybe the documentation should mention that we do not parse timestamps into anything date-related.
Also, please check https://github.com/nlohmann/json/pull/4590/checks?check_run_id=35367015620 on how to sign-off your commits.
Signed-off-by: Michael Valladolid <mikevalladolid@gmail.com>
Please if the commit Treat 0x11 as uint64 and not timestamp specific is aligned with your suggestion. |
Signed-off-by: Michael Valladolid <mikevalladolid@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thank you! |
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
This implements support for BSON uint64 de/serialization.
#4535
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filessingle_include/nlohmann/json.hpp
andsingle_include/nlohmann/json_fwd.hpp
. The whole process is described here.Please don't
#ifdef
s or other means.