Skip to content

BJData Fixes #4588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2025
Merged

BJData Fixes #4588

merged 2 commits into from
Jan 7, 2025

Conversation

nebkat
Copy link
Contributor

@nebkat nebkat commented Jan 7, 2025

Fixes addressing #4513 (review)

Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

nebkat added 2 commits January 7, 2025 19:53
@nebkat
Simplify BJData Draft3 logic in encoder
e07f0b3 
Signed-off-by: Nebojsa Cvetkovic <nebkat@gmail.com>
@nebkat
Fix to_bjdata() parameter docs
732eb1c 
Signed-off-by: Nebojsa Cvetkovic <nebkat@gmail.com>
@nebkat nebkat requested a review from nlohmann as a code owner January 7, 2025 20:28
@coveralls
Copy link

Coverage Status

coverage: 99.639%. remained the same
when pulling 732eb1c on nebkat:develop
into 0cb1241 on nlohmann:develop.

nlohmann
nlohmann approved these changes Jan 7, 2025
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.4 milestone Jan 7, 2025
@nlohmann nlohmann merged commit 48e7b4c into nlohmann:develop Jan 7, 2025
124 checks passed
@nlohmann
Copy link
Owner

nlohmann commented Jan 7, 2025

Thanks!

nebkat added a commit to nebkat/nlohmann-json that referenced this pull request Jan 8, 2025
@nebkat
BJData Fixes (nlohmann#4588)
7987db3
codenut pushed a commit to codenut/json that referenced this pull request Jan 9, 2025
@nebkat @codenut
BJData Fixes (nlohmann#4588)
e52b9aa 
Signed-off-by: Michael Valladolid <mikevalladolid@gmail.com>
@nlohmann nlohmann mentioned this pull request Jan 9, 2025
Merged
4 tasks
slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
@nebkat @slowriot
BJData Fixes (nlohmann#4588)
9de1ccc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

@gregmarr gregmarr gregmarr approved these changes

Assignees
No one assigned
Labels
documentation M
Projects
None yet
Milestone
Release 3.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nebkat @coveralls @nlohmann @gregmarr