Skip to content

fix diagnostic positions related compilation errors #4570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2024
Merged

fix diagnostic positions related compilation errors #4570

merged 1 commit into from
Dec 28, 2024

Conversation

hnampally
Copy link
Contributor

This change fixes the compilation issue #4569 by using the public member functions instead of private members to access the start and end positions

Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

@hnampally hnampally requested a review from nlohmann as a code owner December 28, 2024 00:32
@github-actions github-actions bot added the S label Dec 28, 2024
@coveralls
Copy link

Coverage Status

coverage: 99.639%. remained the same
when pulling 0ac70f1 on harytary:issue4569-compilation-fix-diagnostic_positions
into 6be4e85 on nlohmann:develop.

nlohmann
nlohmann approved these changes Dec 28, 2024
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.4 milestone Dec 28, 2024
@nlohmann nlohmann merged commit 5ff90d9 into nlohmann:develop Dec 28, 2024
123 checks passed
@nlohmann nlohmann linked an issue Dec 28, 2024 that may be closed by this pull request
Compilation issue with cmake option "JSON_Diagnostic_Positions" ON #4569
Closed
2 tasks
@nlohmann nlohmann mentioned this pull request Dec 28, 2024
Closed
2 tasks
slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
@hnampally @slowriot
fix diagnostic positions related compilation errors (nlohmann#4570)
1c50754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees
No one assigned
Labels
S
Projects
None yet
Milestone
Release 3.12.0
Development

Successfully merging this pull request may close these issues.

Compilation issue with cmake option "JSON_Diagnostic_Positions" ON
3 participants
@hnampally @coveralls @nlohmann