fix: integer parsed as float when EINTR set in errno #4506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please run the amalgamation with astyle 3.1. |
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @StuartGorman |
|
Thanks! |
slowriot
pushed a commit
to slowriot/json
that referenced
this pull request
Jan 10, 2025
* fix: integer parsed as float when EINTR set in errno * chore: make amalgamate * chore: make pretty --------- Co-authored-by: Stuart Gorman <Stuart.Gorman@kallipr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Occasionally the OS will set errno to
EINTRif some system call has been interrupted. If that happens inlexer:scan_number()it will be treated the same as errno being set toERANGEdue to the check beingerrno == 0. This will cause valid integers to be parsed as floats.Fix: Changing the errno check to explicitly check for ERANGE, as that is the condition that the parsing code cares about.
Environment:
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmanndirectory, runmake amalgamateto create the single-header filessingle_include/nlohmann/json.hppandsingle_include/nlohmann/json_fwd.hpp. The whole process is described here.