Skip to content

Suppress warnings in NLOHMANN_JSON_SERIALIZE_ENUM #4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2024
Merged

Suppress warnings in NLOHMANN_JSON_SERIALIZE_ENUM #4497

merged 1 commit into from
Nov 17, 2024
+8 −0

Conversation

nlohmann
Copy link
Owner

Fixes #3924.

  • modernize-type-traits: we use C++11 and don't need to implement our own version of std::is_enum_v here
  • modernize-avoid-c-arrays: we don't want to rely on client code to include <array> when using NLOHMANN_JSON_SERIALIZE_ENUM

@github-actions github-actions bot added the S label Nov 17, 2024
@nlohmann nlohmann added this to the Release 3.11.4 milestone Nov 17, 2024
@nlohmann nlohmann self-assigned this Nov 17, 2024
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling d63ade1 on suppress-clang-tidy-warning-in-macro
into 1c5923e on develop.

@nlohmann nlohmann merged commit 64f68dc into develop Nov 17, 2024
129 checks passed
@nlohmann nlohmann deleted the suppress-clang-tidy-warning-in-macro branch November 17, 2024 13:29
slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
@nlohmann @slowriot
Suppress warnings in NLOHMANN_JSON_SERIALIZE_ENUM (nlohmann#4497)
097a5c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
S
Projects
None yet
Milestone
Release 3.12.0
Development

Successfully merging this pull request may close these issues.

modernize-avoid-c-arrays clang-tidy warning when using NLOHMANN_JSON_SERIALIZE_ENUM macro
2 participants
@nlohmann @coveralls