Skip to content

Added checks if $_SERVER['argv'] is set #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2023
Merged

Added checks if $_SERVER['argv'] is set #568

merged 1 commit into from
Jul 30, 2023

Conversation

janfejtek
Copy link
Contributor

  • bug fix
  • BC break? no

Variable argv does not have to be present. First check relates to Helper class, which does not add column into source when run from cli and argv is missing

tracy/src/Tracy/Helpers.php

Line 173 in 209ac30

. (isset($_SERVER['argv']) ? ': ' . implode(' ', array_map([self::class, 'escapeArg'], $_SERVER['argv'])) : '');

@janfejtek janfejtek changed the title Added checks if $_SERVER['argv'] is not set Added checks if $_SERVER['argv'] is set Jul 3, 2023
@dg dg force-pushed the master branch 3 times, most recently from b5f07d2 to 209ac30 Compare July 30, 2023 13:17
@dg dg merged commit d2d5a64 into nette:master Jul 30, 2023
@dg
Copy link
Member

dg commented Jul 30, 2023

Thanks

dg pushed a commit that referenced this pull request Jul 30, 2023
@janfejtek @dg
bluescreen: checks if $_SERVER['argv'] is set (#568)
f299cdf
dg pushed a commit that referenced this pull request Jul 30, 2023
@janfejtek @dg
bluescreen: checks if $_SERVER['argv'] is set (#568)
bcdbae0
dg pushed a commit that referenced this pull request Sep 25, 2023
@janfejtek @dg
bluescreen: checks if $_SERVER['argv'] is set (#568)
900cc92
dg pushed a commit that referenced this pull request Sep 25, 2023
@janfejtek @dg
bluescreen: checks if $_SERVER['argv'] is set (#568)
27f75c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janfejtek @dg