WIP: Upgrade to Fennel version 0.4 #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include fennelfriend module, which shows more friendly error messages upon compilation errors.
Also add fennelfriend compiler helpers into options during compilation. This gives us better error messages, but the "pinpointing" of the error which we have in CLI fennel does not work here, because it depends upon being able to io.open the source file to find the source code which is throwing the error. We need some way of pinpointing errors when the source is only available as a string.
Previously error suggestions could only work when the source file was stored on disk, not when it was a string.
|
Hmm, I see the Amethyst Waters game which is written on Fennel doesn't work now |
|
Yes, definitely. Sorry for the miscommunication here; "WIP" means "work in progress"; I wanted to post this for discussion even though it still needed more testing. =) Thanks for catching this bug! Will get a fix in soon. |
|
Ok I reverted it yet here 8f332b9 |
|
No problem; I'll have something ready by the end of the week. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in the latest version of Fennel, which is 0.4.1-dev. The actual release of 0.4.1 is still a few days away, but the remaining issues do not affect TIC-80 at all. I would like to update this PR later so that it includes the final version of 0.4.1 anyway, but I wanted to open this as WIP so that it doesn't get missed for the 0.8.0 release of TIC.
One big improvement in this version is the reporting when there is a compiler error: