Skip to content

Sort points vertically in ticLine #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2020
Merged

Sort points vertically in ticLine #1061

merged 1 commit into from
Apr 30, 2020

Conversation

ddelemeny
Copy link
Contributor

This fixes the bug discussed at #1059 (comment)

The change seems to only affect tic_api_tri and tic_api_line, effectively fixing the discrepancy caused by point order sensitivity.

nesbox
nesbox reviewed Apr 29, 2020
View reviewed changes
Copy link
Owner

@nesbox nesbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, will test it soon

nesbox
nesbox approved these changes Apr 30, 2020
View reviewed changes
Copy link
Owner

@nesbox nesbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works
thank you :)

@nesbox nesbox merged commit ac14021 into nesbox:master Apr 30, 2020
@nesbox nesbox linked an issue Apr 30, 2020 that may be closed by this pull request
textri seems to be off by one on x axis #1059
Closed
@nesbox nesbox added this to the 0.80.0 milestone Apr 30, 2020
nesbox added a commit that referenced this pull request Apr 30, 2020
@nesbox
#1061: some code opts
6b68e43
@ddelemeny ddelemeny deleted the bugfix-line branch May 2, 2020 20:10
@nesbox nesbox removed this from the 0.80.0 milestone Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesbox nesbox nesbox approved these changes

Assignees

@ddelemeny ddelemeny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

textri seems to be off by one on x axis
2 participants
@ddelemeny @nesbox