-
-
Notifications
You must be signed in to change notification settings - Fork 548
Add sustain to notes and effects on frame change #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
But there's at least a music track or so made on TIC-80 using the note-cutting upon frame transitions. |
Yeah, that's Hyrum's Law. In my opinion, it's more consistent when the note gets sustained, so that each frame is just the continuation of a track, not a break point. What do you think is better? :) |
We have a lot of tracks previously created without the note sustaining and we have to keep compatibility with them. |
Sounds good to me, I'll try to implement that :) |
Great, also we need to add a |
Maybe we should add a settings popup or second screen with this mode, follow mode, and future modes we may add? In this way, the tracker's UI remains clean and only with the most used tools. I don't think people will be constantly toggling follow mode or sustain mode. Plus, a cluttered UI usually turns people off. What do you think? |
That's right, right now there aren't many config options to justify a window. Well, if you add more features in the future you can consider the config window :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, could you pls fix two points I mentioned in the comments?
thank you
Right! Thanks :) I also want to make some tests with all the APIs to ensure nothing went wrong... |
How do you deal with the API reference in the wiki? Should we update it now or after a release? |
Yes, I forgot it, we have to update the wiki with |
Ok. I'll do that then :) |
This fixes #382.
Channels were being reseted each new frame, that caused the notes/effects to stop. Maybe they were being reseted for another specific purpose that I'm unaware of? Now channels are only reseted if the
music_state
istic_music_stop
.EDIT:
Added a cartridge that makes it easier to test the fixed issue:
test-sustain.tic.zip