[WIP] Fixes for 0.1 #3309

tarruda · 2015-09-08T14:16:47Z

The goal of this PR is to fix bugs tagged "milestone:0.1-first-public-release"

justinmk · 2015-09-08T14:40:30Z

src/nvim/ui_bridge.c

@@ -234,8 +234,11 @@ static void ui_bridge_highlight_set_event(void **argv)

 static void ui_bridge_put(UI *b, uint8_t *text, size_t size)


would FUNC_ATTR_NONNULL_ALL work?

No, this function uses NULL in the second cell of double-width cells

Should not it be FUNC_ATTR_NONNULL_ARG(1) then?

Should not it be FUNC_ATTR_NONNULL_ARG(1) then?

👍

justinmk · 2015-09-10T16:50:10Z

src/nvim/search.c

@@ -653,7 +653,7 @@ int searchit(
              }
              if (matchcol == 0 && (options & SEARCH_START))
                break;
-              if (ptr[matchcol] == NUL
+              if (STRLEN(ptr) <= (size_t)matchcol || ptr[matchcol] == NUL


The STRLEN calculation could be moved out of the while-loop (above line 614).

Did you see the comment below(at ml_get_buf)? Even though it is theoretically getting the same line, is it guaranteed that ptr will point to the same string? I'd rather not optimize this prematurely and risk introducing bugs, especially because vim is too complex and hard to have its state predicted after a non-trivial function is called(vim_regexec_multi)

justinmk · 2015-09-10T16:53:53Z

#3016 is another one that 49a850c should fix.

tarruda · 2015-09-15T11:36:40Z

@oni-link continuing the conversation from a rebased commit, you asked:

Groups of 'maxcombine' combining characters. What does vim do? Drop the remaining characters?

From the 'maxcombine' help:

The default is OK for most languages. Hebrew may require 4.
Maximum value is 6.

So I don't think it's possible to have more than 6, which is confirmed by the size of the global variable which stores combining chars:

EXTERN u8char_T *ScreenLinesC[MAX_MCO];         /* composing characters */

Tranquility · 2015-09-18T17:26:48Z

This PR fixes junegunn/fzf#206 for me.

Close neovim#2833

Close neovim#3150

@4b98ea1e80bf changed how refcounts are handled internally to fit into job control semantics. Change the refcount check in `ex_delfunction` to consider this. Close neovim#3000

Ref: junegunn/fzf.vim#8 (comment)

Close neovim#3323

Close neovim#3332

tarruda · 2015-09-18T17:37:38Z

@Tranquility great

Since this PR already fixes quite a few issues, I will merge it later and continue working on the remaining 0.1 issues in a new PR

Since vimscript can close buffers at any time, it is possible that a refresh_timer_cb will be called with an invalid buffer, but there's no way to detect this if only a reference is stored because the memory can be reused by the allocator. Use buf_T->handle which is guaranteed to be unique.

Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8

justinmk · 2015-09-19T14:33:39Z

src/nvim/ui_bridge.c

-  memcpy(t, text, size);
+  uint8_t *t = NULL;
+  if (text) {
+    t = xmalloc(sizeof(((UCell *)0)->data));


Interesting. http://stackoverflow.com/a/19786755/152142

Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8

tarruda mentioned this pull request Sep 8, 2015

&pastetoggle is set to <F37> after initial parsing of the nvimrc #2843

Closed

marvim added the WIP label Sep 8, 2015

justinmk reviewed Sep 8, 2015
View reviewed changes

tarruda force-pushed the fixes-for-0.1 branch 2 times, most recently from 9d4ae5e to 49a850c Compare September 9, 2015 11:10

tarruda mentioned this pull request Sep 10, 2015

History: and History/ commands in Neovim junegunn/fzf.vim#8

Closed

justinmk reviewed Sep 10, 2015
View reviewed changes

justinmk mentioned this pull request Sep 10, 2015

[RFC] Change condition order in :delfunction #3010

Closed

tarruda force-pushed the fixes-for-0.1 branch from 0127946 to 508dc86 Compare September 11, 2015 11:06

This was referenced Sep 11, 2015

utf-8 encoding causing SIGABRT #3323

Closed

Crashes when trying to load Python host #3016

Closed

tarruda force-pushed the fixes-for-0.1 branch 2 times, most recently from bbaff16 to 074035b Compare September 15, 2015 11:14

zenbro mentioned this pull request Sep 15, 2015

[neovim] :FZF crashes when mapping 'open in new tab' to enter junegunn/fzf#313

Closed

tarruda force-pushed the fixes-for-0.1 branch from 074035b to 4f5213f Compare September 16, 2015 07:16

tarruda mentioned this pull request Sep 16, 2015

[neovim] FZF command always reuses same window junegunn/fzf#348

Closed

This was referenced Sep 17, 2015

Segmentation fault when closing win buffer #3354

Closed

Heap use after free when using termopen() #3332

Closed

tarruda force-pushed the fixes-for-0.1 branch 2 times, most recently from a1ac68a to 7c5b2c6 Compare September 18, 2015 16:51

tarruda added 5 commits September 18, 2015 14:35

ui_bridge: Fix passing NULL pointer to memcpy

29b998b

os/path: Fix path_get_absolute_path for top-level paths

c708061

Close neovim#2833

regexp: Fix invalid multibyte reads at end of strings

0a116c8

Close neovim#3150

eval: Fix ex_delfunction to use the uf_refcount field properly

b7dab42

@4b98ea1e80bf changed how refcounts are handled internally to fit into job control semantics. Change the refcount check in `ex_delfunction` to consider this. Close neovim#3000

terminal: Don't enter terminal mode from :normal

1b17164

Ref: junegunn/fzf.vim#8 (comment)

tarruda added 2 commits September 18, 2015 14:35

ugrid: Increase cell size to allow unicode composition

1f90cbb

Close neovim#3323

terminal: Run screen refresh timer in a deferred queue

47cbbc0

Close neovim#3332

tarruda force-pushed the fixes-for-0.1 branch from 7c5b2c6 to eef7218 Compare September 18, 2015 17:35

tarruda force-pushed the fixes-for-0.1 branch from eef7218 to e897cca Compare September 18, 2015 17:50

tarruda merged commit e897cca into neovim:master Sep 18, 2015

tarruda added a commit that referenced this pull request Sep 18, 2015

Merge PR #3309 'Fixes for 0.1'

e80d7c0

jszakmeister removed the WIP label Sep 18, 2015

ZyX-I added a commit to ZyX-I/neovim that referenced this pull request Sep 18, 2015

functests: Do not disable pattern tests

97b00a8

Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8

tarruda mentioned this pull request Sep 19, 2015

[RDY] More fixes for 0.1 #3360

Merged

justinmk reviewed Sep 19, 2015
View reviewed changes

ZyX-I added a commit to ZyX-I/neovim that referenced this pull request Sep 19, 2015

functests: Do not disable pattern tests

3f7c46a

Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8

ZyX-I added a commit to ZyX-I/neovim that referenced this pull request Sep 24, 2015

functests: Do not disable pattern tests

e32b7e6

Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8

ZyX-I added a commit to ZyX-I/neovim that referenced this pull request Sep 25, 2015

functests: Do not disable pattern tests

06c5fc5

Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8

ZyX-I added a commit to ZyX-I/neovim that referenced this pull request Sep 26, 2015

functests: Do not disable pattern tests

c266ccd

Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8

ZyX-I added a commit to ZyX-I/neovim that referenced this pull request Sep 26, 2015

functests: Do not disable pattern tests

d61b17e

Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8

ZyX-I added a commit to ZyX-I/neovim that referenced this pull request Sep 27, 2015

functests: Do not disable pattern tests

d1723fb

Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8

This was referenced Oct 1, 2015

Aborted when opening a dir and a file inside it. #3216

Closed

segfault with multiple buffers open + control-p usage #3070

Closed

ZyX-I added a commit to ZyX-I/neovim that referenced this pull request Oct 1, 2015

functests: Do not disable pattern tests

1b023c9

Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8

ZyX-I added a commit to ZyX-I/neovim that referenced this pull request Oct 3, 2015

functests: Do not disable pattern tests

c104088

Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8

ZyX-I added a commit to ZyX-I/neovim that referenced this pull request Oct 5, 2015

functests: Do not disable pattern tests

633dc3b

Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8

ZyX-I added a commit to ZyX-I/neovim that referenced this pull request Oct 8, 2015

functests: Do not disable pattern tests

410e69e

Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8

ZyX-I added a commit to ZyX-I/neovim that referenced this pull request Oct 8, 2015

functests: Do not disable pattern tests

56a2549

Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8

justinmk mentioned this pull request Oct 23, 2015

split() function is slow for large strings #3486

Closed

mgraczyk pushed a commit to mgraczyk/neovim that referenced this pull request Nov 2, 2015

functests: Do not disable pattern tests

90033be

Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8

justinmk mentioned this pull request Jan 12, 2016

open big file (919990 lines) cost 25 seconds #3987

Closed

justinmk mentioned this pull request Jan 24, 2016

[RFC] regexp_nfa.c: Speed up find_match_text() #4093

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[WIP] Fixes for 0.1 #3309

[WIP] Fixes for 0.1 #3309

Uh oh!

tarruda commented Sep 8, 2015

Uh oh!

justinmk Sep 8, 2015

Uh oh!

tarruda Sep 8, 2015

Uh oh!

ZyX-I Sep 8, 2015

Uh oh!

tarruda Sep 8, 2015

Uh oh!

justinmk Sep 10, 2015

Uh oh!

tarruda Sep 11, 2015

Uh oh!

justinmk commented Sep 10, 2015

Uh oh!

tarruda commented Sep 15, 2015

Uh oh!

Tranquility commented Sep 18, 2015

Uh oh!

tarruda commented Sep 18, 2015

Uh oh!

justinmk Sep 19, 2015

Uh oh!

Uh oh!

		@@ -234,8 +234,11 @@ static void ui_bridge_highlight_set_event(void **argv)

		static void ui_bridge_put(UI b, uint8_t text, size_t size)

Uh oh!

[WIP] Fixes for 0.1 #3309

[WIP] Fixes for 0.1 #3309

Uh oh!

Conversation

tarruda commented Sep 8, 2015

Uh oh!

justinmk Sep 8, 2015

Choose a reason for hiding this comment

Uh oh!

tarruda Sep 8, 2015

Choose a reason for hiding this comment

Uh oh!

ZyX-I Sep 8, 2015

Choose a reason for hiding this comment

Uh oh!

tarruda Sep 8, 2015

Choose a reason for hiding this comment

Uh oh!

justinmk Sep 10, 2015

Choose a reason for hiding this comment

Uh oh!

tarruda Sep 11, 2015

Choose a reason for hiding this comment

Uh oh!

justinmk commented Sep 10, 2015

Uh oh!

tarruda commented Sep 15, 2015

Uh oh!

Tranquility commented Sep 18, 2015

Uh oh!

tarruda commented Sep 18, 2015

Uh oh!

justinmk Sep 19, 2015

Choose a reason for hiding this comment

Uh oh!

Uh oh!