-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
[RFC] Add vim_call_dict_function
to API
#3032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
msgpack-rpc dict + internal=true is not possible, isn’t it? AFAIR function references cannot be passed through the API. |
vim_call_dict_function
to APIvim_call_dict_function
to API
Please rebase on master, now #2979 is merged. |
This change is made to reuse code for vim_call_dict_function.
…o statement Some code paths were able to free the dict, even if it came from the self argument. This would cause segfault if the self object is freed.
@saep Can you rebase this? |
So, I tried to rebase and the result can be found here: saep@3a05715 Mysteriously, this PR isn't updated with the changes I made because github doesn't know where this PR originated from. I can make another PR and reference it here, but the state isn't ready yet. First I tried to build neovim via the nix installation instructions which do not seem to work at all (
Then I tried adjusting the nix expression from nixpkgs, but I wasn't able to run any tests. After googling for half an hour, I gave up and created a debian VM to build and test my changes. This seemed to work initially, but when I tried to debug the failing test cases via
I'm not motivated to continue anymore. Feel free to use my changes in any way you like and finish the PR. |
As Nix rebuilds the package when the package building instructions changes, it can become a problem. Previously nix would rebuild neovim when you changed the runtime configuration (python/ruby support etc) so I pushed a change to distinguish between the 2 in the traditional nix style:
I updated the wiki to account for the changes https://github.com/neovim/neovim/wiki/Building-Neovim I've sent a PR to nixos to revamp the lua support a few months ago. You can run the functional tests with it but as it's a huge PR, it takes time to merge. It's possible to hack LUA_PATH to point at the .deps directory too but there is no out of the box support for running the tests. |
This is an extension of #2979 that provides an API function for calling dict functions.
Note that this branch is based on those changes since I could reuse that code completely for the implementation of the current state.
@ZyX-I proposed this:
Here is a list of things that still have to be discussed, tested or implemented (inclusive or):
false
true
false
true