Skip to content

[RFC] deps: Update unibilium from 1.12 -> 1.14 #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[RFC] deps: Update unibilium from 1.12 -> 1.14 #2665

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 15, 2015

There have been so few commits between these two versions that you can probably review them manually in a few minutes:
mauke/unibilium@v1.1.2...v1.1.4

@marvim marvim added the RFC label May 15, 2015
ghost referenced this pull request in fwalch/neovim May 17, 2015
@fwalch
deps: Update LuaJIT to 2.0.4.
e891274
@fwalch
Copy link
Member

fwalch commented May 17, 2015

There are changes in CFLAGS (in maint.mk), but if I read this correctly, maint.mk is only included when cloning the repository using Git? So it shouldn't be a problem.

LGTM.

@ghost
Copy link
Author

ghost commented May 17, 2015

It's this error (again):

Error -> ...d/neovim/neovim/test/functional/ui/screen_basic_spec.lua @ 490
Screen resize has minimum width/height values
./test/functional/ui/screen.lua:269: Row 1 didnt match.
Expected: "-- INS^ERT --"
Actual:   "resize^      "

I don't think it's anything to worry about though.

deps: Update unibilium 1.12 -> 1.14
d3972d1 
From here[1]:

1.1.4   2015-04-26
        - move maintainer options from GNUmakefile to maint.mk
        - compile with -O2 by default

1.1.3   2015-04-25
        - fix permission error when installing into existing directory
          (gh PR #7)
        - relicense tools/*.c under MIT (gh #9)
        - add change log in Changes

[1]: mauke/unibilium@v1.1.2...v1.1.4
@ghost
Copy link
Author

ghost commented May 19, 2015

The GCC build stalled after 41 minutes, but everything else passed fine. I'll merge this.

ghost pushed a commit that referenced this pull request May 19, 2015
deps: Update unibilium 1.12 -> 1.14 #2665
73137e0 
From here[1]:

1.1.4   2015-04-26
        - move maintainer options from GNUmakefile to maint.mk
        - compile with -O2 by default

1.1.3   2015-04-25
        - fix permission error when installing into existing directory
          (gh PR #7)
        - relicense tools/*.c under MIT (gh #9)
        - add change log in Changes

[1]: mauke/unibilium@v1.1.2...v1.1.4
@ghost ghost closed this May 19, 2015
@jszakmeister jszakmeister removed the RFC label May 19, 2015
@ghost ghost deleted the unibilium-update branch May 19, 2015 00:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fwalch @jszakmeister @marvim