-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Extended marks 2: Electric Boogalo #11356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
// If throw == true then an error will be raised if nothing | ||
// was found | ||
// Returns NULL if something went wrong | ||
ExtendedMark *extmark_from_id_or_pos(Buffer buffer, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used, but keep anyway for future API usage?
I've done some revisions, might do a few more (like a few more obsolete TODO comments and such) but this is pretty much mergable from my point of view. We have the 0.5 cycle to fix bugs/edge cases (which will be reported by master testers after merge :) . This is is pretty much "do nothing unless invoked", so it should not affect stability in general. Docs can and will be improved after merge (but of course point out already if there is something obviously wrong/misleading). I also plan to heavily refactor the internal implementation based on #9404 (a more efficient kbtree that don't need two separate layers for columns/lines) at some point, but this is not critical. There is no catastrophe if this happens after 0.5 (or never). |
@zgpio updated to your suggestions (and a bit more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but I have a doc update pending anyway. There are many typos, but we want to avoid lots of typo comments in this PR. |
@ashfinal Thanks, but note that method-specific documentation in api.txt is generated, so some of those will be overwritten anyway. Method documentation should be reviewed in |
I added comments for the Also fixed the segfault on buffer wipe. |
Merged. Thanks @timeyyy for this great contribution. As mentioned before, this just the start of "extmark" feature. Apart from doc/implementation improvements, an follow-up will be to integrate bufhl/virttext into it, which I hope to look into soon. |
Thanks for getting this slotted in. |
|
#5031 PR thread is too long, so lets open a new one. Tests passes locally after some small adjustments, lets hope for the best.