Kbtree sanity #9404
Closed
Kbtree sanity #9404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
%s/__KB_KEY(key_t, \(\a\+\))/\1->key/g %s/__KB_PTR(b, \(\a\+\))/\1->ptr/g %s/(unsigned int)/(size_t)
justinmk
reviewed
Dec 28, 2018
|
somewhat related, attractivechaos/klib#117 suggests a potential improvement to kvec. |
But it seems nvim has already done those in our private copy. |
|
Added some comments to the algorithms, especially for how |
|
Resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to kbtree to make it possible to step through in a debugger, and make it slightly easier to read.
Probably doesn't make sense to merge right now, but after the initial extmark #5031 is done I might experiment with some changes to make it more effective to our use case: