Skip to content

[RFC] win: stream_init() issue with tty on Windows #9884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2019
Merged

[RFC] win: stream_init() issue with tty on Windows #9884

merged 1 commit into from
Apr 28, 2019

Conversation

erw7
Copy link
Contributor

@erw7 erw7 commented Apr 11, 2019

This pull request has been separated from #9825.

@erw7 erw7 changed the title win: stream_init() issue with tty on Windows [RFC] win: stream_init() issue with tty on Windows Apr 11, 2019
@erw7 erw7 mentioned this pull request Apr 11, 2019
Merged
6 tasks
@marvim marvim added the RFC label Apr 11, 2019
justinmk
justinmk reviewed Apr 28, 2019
View reviewed changes
src/nvim/tui/input.c
uv_tty_set_mode(&input->tty_in, UV_TTY_MODE_RAW);
rstream_init_stream(&input->read_stream,
(uv_stream_t *)&input->tty_in,
0xfff);
Copy link
Member

@justinmk justinmk Apr 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tty_in field is no longer used. I guess it could be removed from struct term_input

Also looks like rstream_init_stream() is no longer used. I guess we should keep it though.

@justinmk justinmk merged commit 8072f08 into neovim:master Apr 28, 2019
This was referenced Jun 1, 2019
Closed
Merged
@justinmk justinmk added this to the 0.4 milestone Jul 22, 2019
justinmk pushed a commit that referenced this pull request Aug 20, 2019
@Escapingbug @justinmk
win: stream: reset tty stream on close
e097e47 
This was overlooked in 8072f08.

Analogous to 8a782f1.

fix #10668
ref 8072f08 #9884
ref 8a782f1 #2377
@erw7 erw7 deleted the fix-stream-init-on-windows branch September 11, 2019 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk justinmk justinmk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@erw7 @justinmk @marvim