Rework Python provider/health check to use neovim module again #9442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The neovim module is available for backwards compatibility. We should not yet force the use of the pynvim module, since there's no other major reason to bump the minimum supported Python client module. Closes neovim#9426
Adapt the checks so we can still report when the pynvim module is present but the neovim module is missing.
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Jan 4, 2019
This maintenance release fixes some issues found in v0.3.2 . FIXES: a597ab8 neovim#9442 Merge pull request from jamessan/revert-pynvim d7b3ac0 health/provider: Check for available pynvim when neovim module missing edeb19d python#CheckForModule: Use the given module string instead of hard-coding pynvim 0dd89cd {health,provider}/python: Import the neovim, rather than pynvim, module fc6e8a4 neovim#9423 TUI: Konsole DECSCUSR fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9438