[RFC] Load-adjust timer tests #9292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
If someone wants to do that, sure. It's not a one-time task: more tests will fail over time, and those need to be monitored, and later fixed. |
|
Then I try looking into the issues of this PR (after I had a look how you handled similar issues earlier). |
20f371d to
2b1c42f
Compare
justinmk
reviewed
Dec 14, 2018
ab21b35 to
e4e4eff
Compare
e39c633 to
c915c12
Compare
cb6d300 to
001c54c
Compare
|
I think this PR is ready now. 💪 (The failing macOS jobs are due to the unrelated |
The Vim version of Test_help_tagjump() tests for `:help sm?le` here. That command got removed from Nvim, so the test was changed to check against `:help sp?it` instead. The new test already handled the case that on Win `:h split` would jump to the entry for split() and on all other systems to the entry for :split. Then this commit happened: bb3aa82 lua/stdlib: vim.inspect, string functions Since then `:h split` would jump to split() for macOS as well! I'm not sure why. Anyway, instead of adding another check for has('mac'), we change the test once more to be more akin to the original test. Instead of testing for :smile, which is exclusive to Vim, we check against :checkhealth, which is exclusive to Nvim.
justinmk
reviewed
Jan 17, 2019
| func Test_oneshot() | ||
| let g:val = 0 | ||
| let timer = timer_start(50, 'MyHandler') | ||
| let slept = WaitFor('g:val == 1') | ||
| call assert_equal(1, g:val) | ||
| if has('reltime') | ||
| call assert_inrange(40, 120, slept) | ||
| call s:assert_inrange(40, 120, slept) |
There was a problem hiding this comment.
would be clearer if LoadAdjust() was explicitly called here
There was a problem hiding this comment.
Yup, but you merged it already. :P I guess we just silently do it the next time that file is changed in any way.
Merged
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
May 18, 2019
Also, don't compute load factor unless load_adjust() was called, it slows down the test suite. ref neovim#9292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test_help_tagjump()