Skip to content

Conversation

janlazo
Copy link
Contributor

@janlazo janlazo commented Aug 7, 2018

vim-patch:8.1.0003: the :compiler command is not tested

Problem: The :compiler command is not tested.
Solution: Add a test. (Dominique Pelle, closes vim/vim#2930)
vim/vim@10561fe

vim-patch:8.1.0004: test for :compiler command sometimes fails

Problem: Test for :compiler command sometimes fails.
Solution: Be less strict about the error message. (Dominique Pelle)
vim/vim@54651f7

vim-patch:8.1.0005: test for :compiler command fails on MS-Windows

Problem: Test for :compiler command fails on MS-Windows.
Solution: Ignore difference in path.
vim/vim@d19b234

8.1.0146 depends on 8.0.1832 so it's not included.

janlazo added 3 commits August 6, 2018 22:53
Problem:    The :compiler command is not tested.
Solution:   Add a test. (Dominique Pelle, closes vim/vim#2930)
vim/vim@10561fe
Problem:    Test for :compiler command sometimes fails.
Solution:   Be less strict about the error message. (Dominique Pelle)
vim/vim@54651f7
Problem:    Test for :compiler command fails on MS-Windows.
Solution:   Ignore difference in path.
vim/vim@d19b234
@janlazo janlazo changed the title vim-patch:8.1.0{3,4,5,146} vim-patch:8.1.000{3,4,5} Aug 7, 2018
call setline(1, ['#!/usr/bin/perl -w', 'use strict;', '$foo=1'])
w!
call feedkeys(":make\<CR>\<CR>", 'tx')
let a=execute('clist')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught exception in Test_compiler(): Vim(clist):E42: No Errors @ function RunTheTest[35]..Test_compiler, line 18

@janlazo
Copy link
Contributor Author

janlazo commented Aug 7, 2018

Postponing this to work on +quickfix patches first. It may fix the execute(clist) issue.

It has nothing to do with +quickfix. perl (msys) cannot use 8.3 paths from tempname() or nvim cannot read the error file of :make. Forgot to set +shellpipe.

Redirect errors from :make to error file.
Fix execption error in test_compiler.vim on Windows.
@janlazo janlazo changed the title vim-patch:8.1.000{3,4,5} [RDY] vim-patch:8.1.000{3,4,5} Aug 8, 2018
@janlazo
Copy link
Contributor Author

janlazo commented Aug 8, 2018

set shellpipe=>%s\ 2>&1 should be the default for cmd.exe.

@marvim marvim added the RDY label Aug 8, 2018
@justinmk justinmk merged commit 8213109 into neovim:master Aug 8, 2018
@justinmk justinmk removed the RDY label Aug 8, 2018
@janlazo janlazo deleted the vim-8.1.0003 branch August 8, 2018 13:29
blueyed added a commit to blueyed/neovim that referenced this pull request Jul 30, 2019
Not sure what happened in daca22f / neovim#8821, but Vim used assert_match /
no expand in vim/vim@d19b23415 (8.1.0005) already.
timeyyy pushed a commit to timeyyy/neovim that referenced this pull request Aug 9, 2019
Not sure what happened in daca22f / neovim#8821, but Vim used assert_match /
no expand in vim/vim@d19b23415 (8.1.0005) already.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants