[RDY] Fix crash in channel_job_start() in combination with rpc and unknown command #8746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamessan
approved these changes
Jul 14, 2018
bfredl
reviewed
Jul 15, 2018
src/nvim/channel.c
Outdated
| @@ -347,6 +348,7 @@ Channel *channel_job_start(char **argv, CallbackReader on_stdout, | |||
| rstream_init(&proc->out, 0); | |||
| } | |||
|
|
|||
| chan->is_rpc = rpc; | |||
There was a problem hiding this comment.
you can even remove this and change next if to rpc, rpc_start will set it to true.
bfredl
reviewed
Jul 15, 2018
src/nvim/channel.c
Outdated
| @@ -288,7 +288,8 @@ Channel *channel_job_start(char **argv, CallbackReader on_stdout, | |||
| chan->on_stdout = on_stdout; | |||
| chan->on_stderr = on_stderr; | |||
| chan->on_exit = on_exit; | |||
| chan->is_rpc = rpc; | |||
| // Prevent channel_destroy_early() from freeing uninitialized rpc stuff | |||
There was a problem hiding this comment.
channel_alloc should return a channel in init state, this is not needed.
There was a problem hiding this comment.
I wanted to make it clear why chan->is_rpc should not be set yet. Should I add a comment further down when using channel_destroy_early() that the rpc part needs to be in its init state?
There was a problem hiding this comment.
Should I add a comment further down when using channel_destroy_early() that the rpc part needs to be in its init state?
This is not true, channel_destroy_early() doesn't need any special condition, it works the same as the ordinary channel freeing function. I don't think the lack of special treatment of rpc channels needs a comment.
… rpc stuff
Without this patch the following commands would crash:
:call rpcstart('unknown_command')
:set sh=unknown_command
:call jobstart('ls',{'rpc':1})
|
@bfredl, applied your review comments. |
bfredl
approved these changes
Jul 15, 2018
justinmk
added a commit
that referenced
this pull request
Jul 18, 2018
FEATURES: 07499a8 #8709 man.vim: C highlighting for EXAMPLES section 07f82ad #8699 TUI: urxvt: also send xterm focus-reporting seqs 40911e4 #8616 API: emit nvim_buf_lines_event from :terminal c46997a #8546 fillchars: Add "eob" flag FIXES: 74d19f6 #8576 startup: avoid blank stdin buffer if other files were opened 4874214 #8737 Only waitpid() for processes that we care about cd6e7e8 #8743 Check all child processes for exit in SIGCHLD handler c230ef2 #8746 channel.c: Prevent channel_destroy_early() from freeing uninitialized rpc stuff 0ed8b12 #8681 transstr_buf: fix length comparison d241f27 #8708 TUI: Fix standout mode 9afed40 #8698 man.vim: fix for mandoc e889640 #8682 provider/node: npm --loglevel silent 1cbc830 #8613 API: nvim_win_set_cursor: set curswant bf6048e #8628 checkhealth: Python: fix VIRTUAL_ENV check 3cc3506 #8528 checkhealth: node.js: also search yarn CHANGES: b751449 #8619 defaults: shortmess+=F 1248178 #8578 highlight: high-priority CursorLine if fg is set. 01570f1 #8726 terminal: handle &confirm and :confirm on unloading 56065bb #8721 screen: truncate showmode messages bf2460e #7551 buffer: fix copying :setlocal options c1c14fa #8520 Ex mode: always "improved" (gQ) 050f397 #7992 options: remove 'maxcombine` option (always 6) INTERNAL: 463da84 #7992 screen: use UTF-8 representation
coditva
pushed a commit
to coditva/neovim
that referenced
this pull request
Jul 28, 2018
FEATURES: 07499a8 neovim#8709 man.vim: C highlighting for EXAMPLES section 07f82ad neovim#8699 TUI: urxvt: also send xterm focus-reporting seqs 40911e4 neovim#8616 API: emit nvim_buf_lines_event from :terminal c46997a neovim#8546 fillchars: Add "eob" flag FIXES: 74d19f6 neovim#8576 startup: avoid blank stdin buffer if other files were opened 4874214 neovim#8737 Only waitpid() for processes that we care about cd6e7e8 neovim#8743 Check all child processes for exit in SIGCHLD handler c230ef2 neovim#8746 channel.c: Prevent channel_destroy_early() from freeing uninitialized rpc stuff 0ed8b12 neovim#8681 transstr_buf: fix length comparison d241f27 neovim#8708 TUI: Fix standout mode 9afed40 neovim#8698 man.vim: fix for mandoc e889640 neovim#8682 provider/node: npm --loglevel silent 1cbc830 neovim#8613 API: nvim_win_set_cursor: set curswant bf6048e neovim#8628 checkhealth: Python: fix VIRTUAL_ENV check 3cc3506 neovim#8528 checkhealth: node.js: also search yarn CHANGES: b751449 neovim#8619 defaults: shortmess+=F 1248178 neovim#8578 highlight: high-priority CursorLine if fg is set. 01570f1 neovim#8726 terminal: handle &confirm and :confirm on unloading 56065bb neovim#8721 screen: truncate showmode messages bf2460e neovim#7551 buffer: fix copying :setlocal options c1c14fa neovim#8520 Ex mode: always "improved" (gQ) 050f397 neovim#7992 options: remove 'maxcombine` option (always 6) INTERNAL: 463da84 neovim#7992 screen: use UTF-8 representation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a crash in channel_job_start() when using rpc and spawning fails by
preventing
channel_destroy_early()from freeing uninitialized rpc stuff.Without this patch the following commands would crash:
:call rpcstart('unknown_command')