build: use Ninja on travis CI; avoid parallel Luarocks bootstrap #8117
Conversation
| ) | ||
|
|
||
| if "%CONFIGURATION:~0,5%" == "MINGW" ( | ||
| :: These are native MinGW builds, but they use the toolchain inside | ||
| :: MSYS2, this allows using all the dependencies and tools available | ||
| :: in MSYS2, but we cannot build inside the MSYS2 shell. | ||
| set CMAKE_GENERATOR="MinGW Makefiles" | ||
| set "CMAKE_GENERATOR=MinGW Makefiles" |
There was a problem hiding this comment.
The quotes need to be part of the variable's value. They can be escaped like this:
set "CMAKE_GENERATOR=^"MinGW Makefiles^""Or you could put quotes around the variable reference like this:
cmake -G "%CMAKE_GENERATOR%"Would you accept a PR replacing this Batch script with a PowerShell script? I think it would be much easier to work with.
There was a problem hiding this comment.
Would you accept a PR replacing this Batch script with a PowerShell script?
Definitely!
There was a problem hiding this comment.
The carets are unnecessary because it's the last argument. When using carets, it's best to use it for each metacharacter, including the double quotes used for wrapping the argument, in the entire command.
set "CMAKE_GENERATOR="MinGW Makefiles"" is fine.
2762c39 to
54b9649
Compare
|
Is MSVC build always hanging on |
|
@janlazo Yes. We merged the MSVC work so that at least luarocks etc. would work. Also so that it can be used for local development. But in the meantime we should probably disable one or both of the MSVC builds until the build failures can be addressed. |
|
Why not disable |
Infinite timeout results in hangs which waste time. If some test needs longer than 10s to wait for a message, it should specify the timeout explicitly.
Is there a race between the luarocks `make bootstrap` dependencies? reverts f73b4911312b35bfe38ed068672a2f8ba8875ba7 ref luarocks/luarocks#774
The MSVC_32 currently hangs. When MSVC becomes the primary Windows target, we can enable MSVC_32 and retire one of the mingw builds. In the meantime it adds too much time.
macOS travis builds recently started failing (travis caches were cleared
recently, maybe related). python2 is reasonably covered by linux CI. Not
going to waste time on it for macOS CI.
==> Installing python@2
==> Downloading https://homebrew.bintray.com/bottles/python@2-2.7.14_3.el_capita
==> Pouring python@2-2.7.14_3.el_capitan.bottle.tar.gz
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3-2
Target /usr/local/bin/2to3-2
is a symlink belonging to python. You can unlink it:
brew unlink python
To force the link and overwrite all conflicting files:
brew link --overwrite python@2
To list all files that would be deleted:
brew link --overwrite --dry-run python@2
Possible conflicting files are:
/usr/local/bin/2to3-2 -> /usr/local/Cellar/python/2.7.12_1/bin/2to3-2
/usr/local/bin/2to3-2.7 -> /usr/local/Cellar/python/2.7.12_1/bin/2to3-2.7
/usr/local/bin/idle -> /usr/local/Cellar/python/2.7.12_1/bin/idle
...
83d3937 to
9cba4f3
Compare
Without this, the CI_TARGET=lint travis job cant't find the cached deps (in $HOME/nvim-deps), nor can it update the cache.
ref #8084