[RDY] Fix for Wrong terminfo value for "standout" #8081

nimitbhardwaj · 2018-02-28T16:43:24Z

Fix the wrong terminfo value sent during the "standout"
Closes #8054

jamessan · 2018-02-28T16:50:10Z

Please provide a useful commit message.

nimitbhardwaj · 2018-02-28T17:00:10Z

May be this is fine

bfredl · 2018-02-28T18:59:41Z

Corresponding change should also be done in hlattrs2dict in src/nvim/ui.c (separate "standout" key)

nimitbhardwaj · 2018-02-28T19:09:13Z

its done, hope it don't disturbs the present tests, I will check the logs if it disturbs tests

bfredl · 2018-02-28T19:11:33Z

src/nvim/ui.c

@@ -186,6 +186,10 @@ Dictionary hlattrs2dict(const HlAttrs *aep, bool use_rgb)
    PUT(hl, "bold", BOOLEAN_OBJ(true));
  }

+  if (mask & HL_STANDOUT) {


Also remove HL_STANDOUT from "reverse" condition below.

Oh yes, I didn't see it, thanks for pointing out

bfredl · 2018-02-28T19:14:10Z

If test is disturbed that is good: now we know what test needs to be updated for new behavior. If no test is disturbed, new test should be added.

nimitbhardwaj · 2018-02-28T19:16:00Z

Oks, cool

nimitbhardwaj · 2018-03-01T06:11:14Z

it does not seems like the test is failed.
So a new test should be added?

teto · 2018-03-03T17:54:25Z

you should test for standout in test/functional/api/highlight_spec.lua, possibly also once in ui/highlight_spec.lua.

nimitbhardwaj · 2018-03-04T20:13:13Z

I made the test hope its correct

bfredl · 2018-03-04T20:38:02Z

test/functional/ui/highlight_spec.lua

+        [3] = {standout = true, underline = true,
+        background = Screen.colors.Gray90}
+    })
+    feed_command('hi CursorLine cterm=standout,underline term=standout,underline gui=standout,underline')


term= can be removed, only cterm and gui should be significant.

OK, yeah, got it

nimitbhardwaj · 2018-03-04T21:11:41Z

Done, I think its work is complete now, unless any other change is necessary, I will squash the commits if needed

nimitbhardwaj · 2018-03-04T21:13:27Z

Squashed

justinmk · 2018-03-27T02:46:29Z

test/functional/ui/highlight_spec.lua

@@ -540,6 +540,27 @@ describe("'listchars' highlight", function()
    ]])
  end)

+  it("'cursorline' and 'standout'", function()


This isn't relevant to the describe("'listchars' highlight", group, so I moved it.

closes #8054

justinmk · 2018-03-27T02:47:29Z

Merged, thanks @nimitbhardwaj !

FEATURES: 3cc7ebf #7234 built-in VimL expression parser 6a7c904 #4419 implement <Cmd> key to invoke command in any mode b836328 #7679 'startup: treat stdin as text instead of commands' 58b210e :digraphs : highlight with hl-SpecialKey #2690 7a13611 #8276 'startup: Let `-s -` read from stdin' 1e71978 events: VimSuspend, VimResume #8280 1e7d5e8 #6272 'stdpath()' f96d99a #8247 server: introduce --listen e8c39f7 #8226 insert-mode: interpret unmapped META as ESC 98e7112 msg: do not scroll entire screen (#8088) f72630b #8055 let negative 'writedelay' show all redraws 5d2dd2e win: has("wsl") on Windows Subsystem for Linux #7330 a4f6cec cmdline: CmdlineEnter and CmdlineLeave autocommands (#7422) 207b7ca #6844 channels: support buffered output and bytes sockets/stdio API: f85cbea #7917 API: buffer updates 418abfc #6743 API: list information about all channels/jobs. 36b2e3f #8375 API: nvim_get_commands 273d2cd #8329 API: Make nvim_set_option() update `:verbose set …` 8d40b36 #8371 API: more reliable/descriptive VimL errors ebb1acb #8353 API: nvim_call_dict_function 9f994bb #8004 API: nvim_list_uis 3405704 #7520 API/UI: forward option updates to UIs 911b1e4 #7821 API: improve nvim_command_output WINDOWS OS: 9cefd83 #8084, #8516 build/win: support MSVC ee4e1fd win: Fix reading content from stdin (#8267) TUI: ffb8904 #8309 TUI: add support for mouse release events in urxvt 8d5a46e #8081 TUI: implement "standout" attribute 6071637 TUI: support TERM=konsole-256color 67848c0 #7653 TUI: report TUI info with -V3 ('verbose' >= 3) 3d0ee17 TUI/rxvt: enable focus-reporting d109f56 #7640 TUI: 'term' option: reflect effective terminal behavior FIXES: ed6a113 #8273 'job-control: avoid kill-timer race' 4e02f1a #8107 'jobs: separate process-group' 451c48a terminal: flush vterm output buffer on pty output #8486 5d6732f :checkhealth fixes #8335 53f11dc #8218 'Fix errors reported by PVS' d05712f inccommand: pause :terminal redraws (#8307) 51af911 inccommand: do not execute trailing commands #8256 84359a4 terminal: resize to the max dimensions (#8249) d49c1dd #8228 Make vim_fgets() return the same values as in Vim 60e96a4 screen: winhl=Normal:Background should not override syntax (#8093) 0c59ac1 #5908 'shada: Also save numbered marks' ba87a2c cscope: ignore EINTR while reading the prompt (#8079) b1412dc #7971 ':terminal Enter/Leave should not increment jumplist' 3a5721e TUI: libtermkey: force CSI driver for mouse input #7948 6ff13d7 #7720 TUI: faster startup 1c6e956 #7862 TUI: fix resize-related segfaults a58c909 #7676 TUI: always hide cursor when flushing, never flush buffers during unibilium output 303e1df #7624 TUI: disable BCE almost always 249bdb0 #7761 mark: Make sure that jumplist item will not have zero lnum 6f41ce0 #7704 macOS: Set $LANG based on the system locale a043899 #7633 'Retry fgets on EINTR' CHANGES: ad60927 #8304 default to 'nofsync' f3f1970 #8035 defaults: 'fillchars' a6052c7 #7984 defaults: sidescroll=1 b69fa86 #7888 defaults: enable cscopeverbose 7c4bb23 defaults: do :filetype stuff unless explicitly "off" 2aa308c #5658 'Apply :lmap in macros' 8ce6393 terminal: Leave 'relativenumber' alone (#8360) e46534b #4486 refactor: Remove maxmem, maxmemtot options 131aad9 win: defaults: 'shellcmdflag', 'shellxquote' #7343 c57d315 #8031 jobwait(): return -2 on interrupt also with timeout 6452831 clipboard: macOS: fallback to tmux if pbcopy is broken #7940 300d365 #7919 Make 'langnoremap' apply directly after a map ada1956 #7880 'lua/executor: Remove lightuserdata' INTERNAL: de0a954 #7806 internal statistics for list impl dee78a4 #7708 rewrite internal list impl

blueyed · 2018-07-08T15:33:56Z

Standout was not working for me: can you please review/check #8708?

nimitbhardwaj force-pushed the wrongTerminfoVal branch from 98e7f21 to 0451487 Compare February 28, 2018 16:59

nimitbhardwaj changed the title ~~[RFC] Wrong terminfo value for "standout"~~ [RFC] Fix for Wrong terminfo value for "standout" Feb 28, 2018

marvim added the RFC label Feb 28, 2018

bfredl reviewed Feb 28, 2018

View reviewed changes

nimitbhardwaj force-pushed the wrongTerminfoVal branch from 0e50137 to bc7cc30 Compare February 28, 2018 19:15

nimitbhardwaj force-pushed the wrongTerminfoVal branch from bc7cc30 to 61ec0d0 Compare March 4, 2018 20:12

bfredl reviewed Mar 4, 2018

View reviewed changes

Fix for wrong terminfo value for "standout"

563be7f

nimitbhardwaj force-pushed the wrongTerminfoVal branch from 3d06cae to 563be7f Compare March 4, 2018 21:13

nimitbhardwaj changed the title ~~[RFC] Fix for Wrong terminfo value for "standout"~~ [RFY] Fix for Wrong terminfo value for "standout" Mar 23, 2018

nimitbhardwaj changed the title ~~[RFY] Fix for Wrong terminfo value for "standout"~~ [RDY] Fix for Wrong terminfo value for "standout" Mar 23, 2018

marvim added RDY and removed RFC labels Mar 23, 2018

justinmk added this to the 0.2.3 milestone Mar 26, 2018

justinmk reviewed Mar 27, 2018

View reviewed changes

justinmk pushed a commit that referenced this pull request Mar 27, 2018

TUI: implement "standout" attribute #8081

8d5a46e

closes #8054

justinmk closed this Mar 27, 2018

justinmk removed the RDY label Mar 27, 2018

justinmk added the gsoc community: Google Summer of Code project label Apr 24, 2018

Uh oh!

[RDY] Fix for Wrong terminfo value for "standout" #8081

[RDY] Fix for Wrong terminfo value for "standout" #8081

Uh oh!

Conversation

nimitbhardwaj commented Feb 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamessan commented Feb 28, 2018

Uh oh!

nimitbhardwaj commented Feb 28, 2018

Uh oh!

bfredl commented Feb 28, 2018

Uh oh!

nimitbhardwaj commented Feb 28, 2018

Uh oh!

bfredl Feb 28, 2018

Choose a reason for hiding this comment

Uh oh!

nimitbhardwaj Feb 28, 2018

Choose a reason for hiding this comment

Uh oh!

bfredl commented Feb 28, 2018

Uh oh!

nimitbhardwaj commented Feb 28, 2018

Uh oh!

nimitbhardwaj commented Mar 1, 2018

Uh oh!

teto commented Mar 3, 2018

Uh oh!

nimitbhardwaj commented Mar 4, 2018

Uh oh!

bfredl Mar 4, 2018

Choose a reason for hiding this comment

Uh oh!

nimitbhardwaj Mar 4, 2018

Choose a reason for hiding this comment

Uh oh!

nimitbhardwaj commented Mar 4, 2018

Uh oh!

nimitbhardwaj commented Mar 4, 2018

Uh oh!

justinmk Mar 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmk commented Mar 27, 2018

Uh oh!

blueyed commented Jul 8, 2018

Uh oh!

Uh oh!

nimitbhardwaj commented Feb 28, 2018 •

edited

Loading

justinmk Mar 27, 2018 •

edited

Loading