[RFC] cmake,bsd: Fix mandir to saner defaults. #7417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old behaviour was to set CMAKE_INSTALL_MANDIR to /usr/local/man when MANPREFIX wasn't defined. This caused mismatching installation paths when the installation prefix wasn't /usr/local. This fix explicitely checks that the prefix is /usr/local to change the value of CMAKE_INSTALL_MANDIR, and uses the default behaviour otherwise, as /usr/local is the exception rather than the norm (as per man hier(7)).
|
@Snaipe Thanks! |
sameedali
added a commit
to sameedali/neovim
that referenced
this pull request
Oct 24, 2017
* 'master' of https://github.com/neovim/neovim: (554 commits) test: tabstop=<big-number> neovim#2838 plines_win_nofold(): Ignore virtcols after 32000th computation neovim#3527 :cquit : take an error code argument neovim#7336 vim-patch:8.0.0140 (neovim#7428) cmake,bsd: Fix mandir to saner defaults. (neovim#7417) help, man.vim: change "outline" map to gO (neovim#7405) build: set MIN_LOG_LEVEL correctly (neovim#7419) vim-patch:8.0.1019 vim-patch:8.0.0962 bufhl: support creating new groups lint refactor/single-include: undo.h refactor/single-include: undo_defs.h refactor/single-include: syntax_defs.h refactor/single-include: regexp_defs.h refactor/single-include: terminal.h vim-patch:8.0.0118 :checkhealth : validate $VIM ex_checkhealth: call health#check() directly doc: E5009 "Invalid $VIMRUNTIME" ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old behaviour was to set CMAKE_INSTALL_MANDIR to /usr/local/man
when MANPREFIX wasn't defined. This caused mismatching installation
paths when the installation prefix wasn't /usr/local.
This fix explicitely checks that the prefix is /usr/local to change
the value of CMAKE_INSTALL_MANDIR, and uses the default behaviour
otherwise, as /usr/local is the exception rather than the norm
(as per man hier(7)).
Tested prefixes are:
/usr/usr/share/man/usr/local/usr/local/man$HOME/.local$HOME/.local/share/manThese paths should be correct according to hier(7), and compatible with the XDG defaults.
This fixes #7239.