[RFC] Disable syntax folding update in InsertLeave #5426

Shougo · 2016-10-04T14:05:22Z

It fixes the slowness in InsertLeave if you use syntax/expr folding.

justinmk · 2016-10-18T14:17:49Z

Did you have any updates to this? Or is it ready?

justinmk · 2016-10-18T14:21:16Z

src/nvim/fold.c

+  if (foldmethodIsManual(curwin)
+      || foldmethodIsSyntax(curwin)
+      || foldmethodIsExpr(curwin)) {
+    return;


Why are only these skipped, but not other fold methods?

I think them should be updated.
manual: No need to update
syntax and expr: Auto update is slow. It should be updated manually like FastFold plugin

Shougo · 2016-10-18T21:56:00Z

Did you have any updates to this? Or is it ready?

It is ready.

justinmk · 2016-10-19T00:23:12Z

Merged

Shougo · 2016-10-19T22:41:23Z

Thank you!

choco · 2016-10-20T09:27:23Z

I understand the reasoning behind this change, but how can I update the folds manually now? zx and zX don't really do what I want.
It would be cool if this change also included a :foldupdate command so I can call it when I want the folds updated.

justinmk · 2016-10-20T10:10:50Z

@Shougo What do you think?

Shougo · 2016-10-20T13:04:47Z

@choco Please change foldmethod value. It resets the folds.

justinmk · 2016-10-20T13:08:32Z

@choco Which foldmethod are you using? And why doesn't zx work for you?

Shougo · 2016-10-20T13:11:03Z

Oh, I get it.
I don't use zx ever...

choco · 2016-10-20T13:14:29Z

@Shougo that works, but it isn't really "user friendly" :/ I still think a command would be worth it.

@justinmk I'm using syntax. zx also reapplys fold level, so some folds that weren't closed get closed, etc....

Anyway this behaviour change should probably be noted in the documentation.

Shougo · 2016-10-20T13:17:15Z

Hm. Vim already have foldopen, foldclose, ... commands.
Why no :foldupdate command in Vim.

Shougo · 2016-10-20T13:25:28Z

@choco Can you ask the question in the issue?

vim/vim#1045

justinmk · 2016-10-20T13:45:12Z

Wait. Why would we add :foldupdate after we just disabled auto-update-of-folds? If this PR broke something we should let auto-updating happen after insert-leave.

choco · 2016-10-20T14:00:08Z

After #5299 and #5351 folds weren't updated in insert mode while typing, but only when leaving it. This PR disabled folds update at insert leave for the slower modes (and manual since it doesn't need updating anyway).

So this PR broke previous behaviour, new text inserted doesn't update folds. Just commented since I think:

change should be mentioned in the documentation, users expect folds to autoupdate.
add a foldupdate command (complementary to foldopen etc.. since zx also reapplys fold level) to have a friendly way to update folds.

justinmk · 2016-10-20T14:05:51Z

This PR disabled folds update at insert leave for the slower modes (and manual since it doesn't need updating anyway).

If user has to manually call (or map) :foldupdate it seems like we didn't improve anything. We went from "slow insert-leave" to "user needs to pay attention and manage their folds".

So I think we should auto-update folds after insert-leave, for everything except foldmethod=manual.

Shougo · 2016-10-20T14:18:39Z

So I think we should auto-update folds after insert-leave, for everything except foldmethod=manual.

I don't like the auto update.
It is slow even if you edit 4000 lines help file.

choco · 2016-10-20T14:21:24Z

So I think we should auto-update folds after insert-leave, for everything except foldmethod=manual.

Well, updating at insert leave feels really bad when editing even moderately big files :( I personally would call foldupdate on BufWrite or manually.

The best solution would be to optimize syntax fold method but last time I took a look most of the time is spent in the regex engine, so I don't think there's a lot that can be done there without moving away from it.

Shougo · 2016-10-20T14:25:00Z

Here.
vim/vim#1045 (comment)

justinmk · 2016-10-20T14:29:03Z

Ok, how about doing it on CursorHold and BufWrite ?

Shougo · 2016-10-20T14:36:14Z

CursorHold is also slow.
But BufWritePost timing is not so bad.

choco · 2016-10-24T20:00:54Z

Yeah BufWritePost seems reasonable 👍

FEATURES: 0b5a7e4 neovim#4432 API: external UIs can render custom popupmenu c6ac4f8 neovim#4934 API: call any API method from vimscript 31df051 neovim#4568 API: nvim_call_atomic(): multiple calls in a single request b268ba3 neovim#5424 API: nvim_win_get_number(), nvim_tabpage_get_number() e7e2844 has("nvim-1.2.3") checks for a specific Nvim version 522b885 neovim#5295, neovim#5493 `:CheckHealth` checks tmux, terminfo, performance 719dae2 neovim#5384 events: allow event processing in getchar() f25797f neovim#5386 API: metadata: Nvim version & API level 22dfe69 neovim#5389 API: metadata: "since", "deprecated_since" 605e743 Added QuickFixLine highlight group CHANGES: 4af6ec7 neovim#5253 perf: Disable clipboard in do_cmdline() 6e9f329 neovim#5299 perf: Skip foldUpdate() in insert-mode. 9d4fcec neovim#5426 perf: Do not auto-update folds for some foldmethods. eeec0ca neovim#5419 tui: Default to normal-mode cursor shape. FIXES: e838452 neovim#5436 tui: Fix "weird characters" / "bleeding termcodes" 10a54ad neovim#5243 signal_init: Always unblock SIGCHLD. bccb49b neovim#5316 eval.c: Fix memory leak for detached pty job 626065d neovim#5227 tchdir: New tab should inherit CWD. cd321b7 neovim#5292 getcwd(): Return empty string if CWD is invalid. 6127eae shada: Fix non-writeable ShaDa directory handling ca65514 neovim#2789 system(): Respect shellxescape, shellxquote 2daf54e neovim#4874 Restore vim-like tab dragging 0c536b5 neovim#5319 syntax.c: Support bg/fg special color-names. 3c53371 neovim#4972 from justinmk/schedule-ui_refresh 68bcb32 neovim#4789 tui.c: Do not wait for tui loop on teardown. c8b6ec2 neovim#5409 v:count broken in command-line window 6bc3bce neovim#5461 fix emoji display 51937e1 neovim#5470 fix :terminal with :argadd, :argu 79d77da neovim#5481 external UIs: opening multiple files from command-line 657ba62 neovim#5501 rplugin: resolve paths in manifest file 6a6f188 neovim#5502 system('foo &', 'bar'): Show error, don't crash. 1ff162c neovim#5515 os_nodetype: open fd with O_NONBLOCK 2a6c5bb neovim#5450 modeline: Handle version number overflow. 0ade1bb neovim#5225 CI tests now run against Windows!

Shougo · 2016-10-31T14:10:29Z

I have fixed the problem in insert mode.
But foldmethod is also slow in normal mode. Oh, no...
Shougo/neosnippet.vim#356

justinmk · 2016-11-08T13:26:18Z

zx also reapplys fold level, so some folds that weren't closed get closed, etc....

@choco Does zizi help? What about doing another set foldenable?

choco · 2016-11-16T23:32:04Z

@justinmk nope, Shougo method above is the only one working

justinmk · 2016-11-16T23:37:50Z

anyone want to send a patch for :foldupdate ?

choco · 2016-11-16T23:45:33Z

If there's no rush I can probably send something (since I'm also the one bugging about it :>), but not before next weekend.

justinmk · 2017-03-03T23:15:06Z

@choco Instead of :foldupdate, it might be enough to CTRL-L. Could you try that?

References neovim#5426 (comment) References neovim#5426 References neovim#5299

choco · 2017-03-04T16:19:34Z

@justinmk Yep, it seems to work indeed. Sorry for not getting back before, been pretty busy last couple of months.

References neovim#5426 (comment) References neovim#5426 References neovim#5299

choco · 2017-03-05T11:13:08Z

@justinmk just wanted to point out that I tried to apply the fix in the pull request above and it doesn't work. I still need to press ctrl-L for the folds to update.

Disable syntax folding update in InsertLeave

d33fc8b

justinmk reviewed Oct 18, 2016

View reviewed changes

Shougo changed the title ~~Disable syntax folding update in InsertLeave~~ [RFC] Disable syntax folding update in InsertLeave Oct 18, 2016

marvim added the RFC label Oct 18, 2016

justinmk closed this Oct 19, 2016

justinmk pushed a commit that referenced this pull request Oct 19, 2016

folds: Do not auto-update folds for some foldmethods. #5426

9d4fcec

justinmk removed the RFC label Oct 19, 2016

Shougo deleted the fold branch October 19, 2016 22:41

justinmk added a commit to justinmk/neovim that referenced this pull request Mar 3, 2017

fold: CLEAR window after insert-leave

8a33f72

References neovim#5426 (comment) References neovim#5426 References neovim#5299

justinmk mentioned this pull request Mar 3, 2017

fold: CLEAR window after insert-leave #6208

Closed

justinmk added a commit to justinmk/neovim that referenced this pull request Mar 4, 2017

fold: CLEAR window after insert-leave

2e08bc6

References neovim#5426 (comment) References neovim#5426 References neovim#5299

justinmk mentioned this pull request Oct 6, 2023

bug: expr-based folds not set by vim.cmd.edit #25518

Open

Uh oh!

[RFC] Disable syntax folding update in InsertLeave #5426

[RFC] Disable syntax folding update in InsertLeave #5426

Uh oh!

Conversation

Shougo commented Oct 4, 2016

Uh oh!

justinmk commented Oct 18, 2016

Uh oh!

justinmk Oct 18, 2016

Choose a reason for hiding this comment

Uh oh!

Shougo Oct 18, 2016

Choose a reason for hiding this comment

Uh oh!

Shougo commented Oct 18, 2016

Uh oh!

justinmk commented Oct 19, 2016

Uh oh!

Shougo commented Oct 19, 2016

Uh oh!

choco commented Oct 20, 2016

Uh oh!

justinmk commented Oct 20, 2016

Uh oh!

Shougo commented Oct 20, 2016

Uh oh!

justinmk commented Oct 20, 2016

Uh oh!

Shougo commented Oct 20, 2016

Uh oh!

choco commented Oct 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shougo commented Oct 20, 2016

Uh oh!

Shougo commented Oct 20, 2016

Uh oh!

justinmk commented Oct 20, 2016

Uh oh!

choco commented Oct 20, 2016

Uh oh!

justinmk commented Oct 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shougo commented Oct 20, 2016

Uh oh!

choco commented Oct 20, 2016

Uh oh!

Shougo commented Oct 20, 2016

Uh oh!

justinmk commented Oct 20, 2016

Uh oh!

Shougo commented Oct 20, 2016

Uh oh!

choco commented Oct 24, 2016

Uh oh!

Shougo commented Oct 31, 2016

Uh oh!

justinmk commented Nov 8, 2016

Uh oh!

choco commented Nov 16, 2016

Uh oh!

justinmk commented Nov 16, 2016

Uh oh!

choco commented Nov 16, 2016

Uh oh!

justinmk commented Mar 3, 2017

Uh oh!

choco commented Mar 4, 2017

Uh oh!

choco commented Mar 5, 2017

Uh oh!

Uh oh!

choco commented Oct 20, 2016 •

edited

Loading

justinmk commented Oct 20, 2016 •

edited

Loading