Add artist play button #4204

deluan · 2025-06-09T22:27:52Z

Summary

add Play button to ArtistActions
fetch top songs via Subsonic API and play them
support translation for the new button
mock and test artist Play button behaviour

Testing

npm run lint
npm run check-formatting
npm test
npm run type-check
make test

https://chatgpt.com/codex/tasks/task_b_68475a045d58832e806aedb0c71466d1

gemini-code-assist

Hello @deluan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! gemini-code-assist here, providing a summary of this pull request. This PR introduces a new 'Play' button to the Artist actions toolbar. Clicking this button will fetch the top 50 songs for the current artist using the Subsonic API and then add them to the playback queue, starting playback. The changes involve adding the button UI, implementing the logic to call the Subsonic API and handle the response, integrating the new API call into the Subsonic client module, adding necessary internationalization strings, and including corresponding tests for the new functionality.

Highlights

New 'Play' Button: Adds a new 'Play' button to the ArtistActions component, displayed alongside the existing 'Shuffle' and 'Radio' buttons.
Fetch Top Songs: Implements a new handler (handlePlay) that uses the Subsonic API's getTopSongs endpoint to retrieve the top 50 tracks for the selected artist.
Playback Integration: Upon successfully fetching top songs, the PR dispatches the playTracks action to add the retrieved songs to the player queue and begin playback.
Subsonic API Client Update: Adds a new function (getTopSongs) to the subsonic client module to encapsulate the API call for fetching top songs.
Internationalization: Includes new translation keys in the English language file for the 'Play' button label and a message for when no top songs are found.
Testing: Adds unit tests for the ArtistActions component to verify that clicking the new 'Play' button correctly calls the getTopSongs API and dispatches the playTracks action.

Changelog

Click here to see the changelog

ui/src/artist/ArtistActions.jsx
- Imported PlayArrowIcon for the new button.
- Imported the subsonic client module.
- Added a new handlePlay asynchronous function.
- The handlePlay function calls subsonic.getTopSongs with the artist name and a count of 50.
- Includes error handling and notification logic for the API call and when no songs are found.
- Processes the API response to extract song data and IDs.
- Dispatches the playTracks action with the fetched song data and IDs.
- Added a new Button component for the 'Play' action, using the handlePlay handler and a translated label.
ui/src/artist/ArtistActions.test.jsx
- Modified the subsonic mock to include the getTopSongs function.
- Added a mock resolved value for subsonic.getTopSongs in the beforeEach block.
- Added a new test case 'plays top songs when Play is clicked'.
- The new test renders the component, clicks the 'Play' button, and asserts that subsonic.getTopSongs was called with the correct arguments and mockDispatch was called.
ui/src/i18n/en.json
- Added the translation key resources.artist.actions.play with the value 'Play'.
- Added the translation key message.noTopSongsFound with the value 'No top songs found'.
ui/src/subsonic/index.js
- Added a new function getTopSongs that constructs and performs an HTTP GET request to the 'getTopSongs' Subsonic endpoint.
- Exported the new getTopSongs function.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a 'Play' button for artists, allowing users to quickly play an artist's top songs. The changes include fetching data from the Subsonic API, handling internationalization, and adding corresponding tests. The implementation is generally clear and follows existing patterns.

I've focused my review on correctness and test coverage, adhering to common JavaScript and React best practices as no specific style guide was provided.

A few suggestions are provided to enhance API response handling and test completeness. Addressing these would further improve the robustness of the new feature.

Summary of Findings

API Response Robustness: Suggested an improvement in ArtistActions.jsx for handling the Subsonic API response structure more robustly, specifically by checking if the data object (from res.json['subsonic-response']) is valid before accessing its properties. This aims to provide more specific error messages for malformed API responses.
Test Coverage: Recommended adding further test cases in ArtistActions.test.jsx for the handlePlay function. Specifically, tests for scenarios where the API call to getTopSongs fails and where the API call succeeds but returns no songs would enhance the test suite's completeness.
Magic Number (Low Severity - Not commented): The number 50 used for fetching top songs in ArtistActions.jsx (line 60) and its corresponding test (line 100) is a magic number. For improved maintainability and clarity, consider defining this as a named constant. (This was not added as a direct review comment due to severity settings.)
Console Logging (Low Severity - Not commented): console.error is used for logging errors in ArtistActions.jsx (e.g., line 84). While acceptable, especially during development, for a production environment, integrating with a more structured logging service or utility could offer better error tracking and diagnostics. This is consistent with existing code in the file. (This was not added as a direct review comment due to severity settings.)

Merge Readiness

The pull request successfully adds the 'Play' button functionality for artists. The code is well-structured and includes tests for the primary success path.

I have made a couple of suggestions with medium severity related to improving the robustness of API response handling and expanding test coverage for edge cases. Addressing these points would strengthen the new feature.

As I am an AI assistant, I am not authorized to approve pull requests. Please ensure these changes are reviewed and approved by a repository maintainer before merging. I recommend addressing the medium-severity issues before merging.

ui/src/artist/ArtistActions.jsx

ui/src/artist/ArtistActions.test.jsx

github-actions · 2025-06-09T22:34:58Z

Signed-off-by: Deluan <deluan@navidrome.org>

Copilot

Pull Request Overview

This PR adds a Play button to the artist toolbar, fetches and plays an artist’s top tracks via the Subsonic API, wires up translations, and covers the new behavior with tests.

Introduce getTopSongs in the Subsonic client and a playTopSongs helper in artist/utils.js
Add a Play button in ArtistActions.jsx and its translation keys
Extend tests to cover Play action and refactor MUI theme import

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ui/src/utils/playSimilar.js	Removed unused legacy playSimilar utility
ui/src/utils/index.js	Dropped export for `playSimilar`
ui/src/subsonic/index.js	Added `getTopSongs` API wrapper
ui/src/i18n/en.json	Added “play” and “noTopSongsFound” translation keys
ui/src/artist/utils.js	New helpers: `playTopSongs`, `playSimilar`, `playShuffle`
ui/src/artist/ArtistActions.jsx	Imported PlayArrowIcon, added Play button and handler
ui/src/artist/ArtistActions.test.jsx	Updated tests for Play action, renamed createMuiTheme

Comments suppressed due to low confidence (1)

ui/src/artist/utils.js:4

The parameter id in playTopSongs is ambiguous and is actually used for the artist identifier. Rename it to artistId (or artistName) and adjust usages so it takes record.id consistently.

export const playTopSongs = async (dispatch, notify, id) => {

ui/src/artist/ArtistActions.jsx

ui/src/artist/ArtistActions.test.jsx

Signed-off-by: Deluan <deluan@navidrome.org>

* ui: add Play button to artist toolbar * refactor Signed-off-by: Deluan <deluan@navidrome.org> * test(ui): add tests for Play button functionality in ArtistActions Signed-off-by: Deluan <deluan@navidrome.org> * ui: update Play button label to Top Songs in ArtistActions Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org>

ui: add Play button to artist toolbar

40472b5

deluan added the codex label Jun 9, 2025 — with ChatGPT Codex Connector

gemini-code-assist bot reviewed Jun 9, 2025

View reviewed changes

gemini-code-assist bot suggested changes Jun 9, 2025

View reviewed changes

ui/src/artist/ArtistActions.jsx Outdated Show resolved Hide resolved

ui/src/artist/ArtistActions.test.jsx Outdated Show resolved Hide resolved

deluan added 2 commits June 9, 2025 18:40

refactor

bf0eb2e

Signed-off-by: Deluan <deluan@navidrome.org>

test(ui): add tests for Play button functionality in ArtistActions

ff46643

Signed-off-by: Deluan <deluan@navidrome.org>

deluan marked this pull request as ready for review June 9, 2025 22:53

deluan requested a review from Copilot June 9, 2025 22:53

Copilot AI reviewed Jun 9, 2025

View reviewed changes

ui/src/artist/ArtistActions.jsx Show resolved Hide resolved

ui/src/artist/ArtistActions.test.jsx Show resolved Hide resolved

ui: update Play button label to Top Songs in ArtistActions

b346fc6

Signed-off-by: Deluan <deluan@navidrome.org>

deluan force-pushed the dkqva6-codex/add-play-button-to-artistactions-toolbar branch from b9cbe8a to b346fc6 Compare June 9, 2025 23:03

deluan merged commit 6e1f207 into master Jun 9, 2025
20 checks passed

deluan deleted the dkqva6-codex/add-play-button-to-artistactions-toolbar branch June 9, 2025 23:07

BrewTestBot mentioned this pull request Jul 1, 2025

navidrome 0.57.0 Homebrew/homebrew-core#228738

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add artist play button #4204

Add artist play button #4204

Uh oh!

deluan commented Jun 9, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 9, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Add artist play button #4204

Add artist play button #4204

Uh oh!

Conversation

deluan commented Jun 9, 2025

Summary

Testing

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Changelog

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Summary of Findings

Merge Readiness

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 9, 2025 •

edited

Loading