Add queue name validation #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 5 | 0 | 0.2s | |
| ✅ COPYPASTE | jscpd | yes | no | 2.0s | |
| ✅ CREDENTIALS | secretlint | yes | no | 1.1s | |
| ✅ GIT | git_diff | yes | no | 0.01s | |
| ✅ JAVASCRIPT | standard | 1 | 0 | 0 | 1.61s |
| ✅ JSON | eslint-plugin-jsonc | 7 | 0 | 0 | 1.1s |
| ✅ JSON | jsonlint | 7 | 0 | 2.12s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 1.35s |
| ✅ JSON | v8r | 7 | 0 | 8.0s | |
| markdownlint | 2 | 0 | 1 | 0.44s | |
| ✅ MARKDOWN | markdown-link-check | 2 | 0 | 4.43s | |
| ✅ MARKDOWN | markdown-table-formatter | 2 | 0 | 0 | 0.33s |
| ✅ SPELL | cspell | 81 | 0 | 5.17s | |
| ✅ SPELL | misspell | 81 | 0 | 0 | 0.16s |
| ✅ TYPESCRIPT | eslint | 54 | 0 | 0 | 15.47s |
| ✅ YAML | prettier | 8 | 0 | 0 | 1.75s |
| ✅ YAML | v8r | 8 | 0 | 10.08s | |
| ✅ YAML | yamllint | 8 | 0 | 0.33s |
See errors details in artifact MegaLinter reports on CI Job page
|
@yeraydavidrodriguez the max length is 30, not 50 because 50 is the recommended max length for a git commit subject. |
josecelano
requested changes
Mar 16, 2022
josecelano
approved these changes
Mar 17, 2022
josecelano
approved these changes
Mar 17, 2022
josecelano
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #39
This PR will add validation to queue names. This is made with a test against this regular expression: [a-z-_ ]{1,50} (from 1 to 50 characters long, only lowercase letters, blank spaces, dashes and underscores)
Also, the blank spaces are translated into dashes after the validation.
Tests are included.