generated from actions/typescript-action
-
Notifications
You must be signed in to change notification settings - Fork 3
Closed
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
We are adding the queue name to the commit subject:
📝✅: queue_name: job.ref.1e31b549c630f806961a291b4e3d4a1471f37490
Git recommends keeping the commit first line (commit subject) with less than 50 characters.
I think it's a good idea to limit the queue size to 30 characters.
We can also replace special characters:
My proposal is to accept only lowercase letters from a to z, dash and white space. But we replace the whitespace by a -
Regexp: https://regex101.com/r/Hd2nQA/1
Valid examples:
queue
queue-name
queue name -> queue-name
Invalid examples:
📝
long-----------------queue-name (31 chars)
QueueName
!"·$%&/()=?¿[]ḉ{}.:;name
queue name -> queue-name
ABCDEFGHIJKLMNÑOPQRSTUVWXYZ
Any other suggestion @da2ce7 @yeraydavidrodriguez ? We could also replace or remove all invalid characters.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers