[FIXED] LeafNode: Don't forward shadow sub unsubscribe if spoke leafnode #7259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to PR #5519 where the propagation of a shadow subscription was suppressed for a subscription coming from a spoke leafnode connection, but the handling of the unsubscribe of such shadow subscription was not fixed, which could result in removing a legitimate interest. The test `TestLeafNodeDupeDeliveryQueueSubAndPlainSub` that was added in PR #5519 was modified to demonstrate what would have been the issue without the fix in this PR. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@derekcollison This is the handling of the unsub of a shadow subscription that was not done in PR #5519 that you fixed last year. |
neilalexander
added a commit
that referenced
this pull request
Sep 8, 2025
Includes the following: - #7200 - #7201 - #7202 - #7209 - #7210 - #7211 - #7213 - #7212 - #7216 - #7217 - #7230 - #7239 - #7246 - #7248 - 8241a15, specifically delayed errors that are not JS API errors - #7158 (not containing 2.12-specific changes) - #7233 - #7255 - #7249 - #7259 - #7265 - #7273 (not including Go 1.25.x) - #7258 - #7222 Signed-off-by: Maurice van Veen <github@mauricevanveen.com> Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to PR #5519 where the propagation of a shadow subscription was suppressed for a subscription coming from a spoke leafnode connection, but the handling of the unsubscribe of such shadow subscription was not fixed, which could result in removing a legitimate interest.
The test
TestLeafNodeDupeDeliveryQueueSubAndPlainSubthat was added in PR #5519 was modified to demonstrate what would have been the issue without the fix in this PR.Signed-off-by: Ivan Kozlovic ivan@synadia.com