Fix account JWT updates disconnecting oldest connections #7181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0e945e to
93f42e4
Compare
Behavior introduced in v2.10.19, but original design was to disconnect the newest ones so reverting back to original behavior. This would have happened on account JWT updates, also added coverage for when enforcing cluster wide limits. Signed-off-by: Waldemar Quevedo <wally@nats.io>
jnmoyne
reviewed
Aug 19, 2025
neilalexander
added a commit
that referenced
this pull request
Aug 19, 2025
…irst (#7185) #7181 mentioned #5757 introduced a regression as observed by `TestAccountMaxConnectionsDisconnectsNewestFirst`. However, that bug has been in there since 2.9.0 or earlier, so it can't be attributed to that PR. Both tests are failing all the way to that version. `TestAccountUpdateRemoteServerDisconnectsNewestFirst` was actually fixed since #5757. [skip ci] Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
neilalexander
added a commit
that referenced
this pull request
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that only newest connections are disconnected on JWT updates.
Signed-off-by: Waldemar Quevedo wally@nats.io