(2.12) [FIXED] Validate stream/consumer configs #7134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c2f722 to
351452a
Compare
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
351452a to
52756c3
Compare
ploubser
reviewed
Aug 12, 2025
| if config.MaxWaiting < 0 { | ||
| config.MaxWaiting = 0 | ||
| } | ||
| if config.MaxAckPending < 0 { |
There was a problem hiding this comment.
I'm currently working on the terraform provider and I think this has introduced a change in behaviour for us. If a consumer was created with max_ack_pending=-1 the value wasn't changed on creation. Now with it being set to 1000 a user of the provider will see drift in the resource that they're not expecting.
@ripienaar for visibility
There was a problem hiding this comment.
Yeah these value changes should only happen when pedantic is false
neilalexander
added a commit
that referenced
this pull request
Aug 13, 2025
…ending -1 default (#7164) Follow-up of #7134 based on #7134 (comment) and nats-io/jsm.go#693. `max_ack_pending` should default to a minimum of -1. And add pedantic handling to all minimums. Also removes the `pedantic mode:` prefix in the pedantic error, because it resulted in `pedantic mode: pedantic mode: {err}`, as the pedantic error already adds the prefix. Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
neilalexander
added a commit
that referenced
this pull request
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a bunch of stream and consumer settings that could be set to invalid values. A few examples include a
MaxBytesof a large negative number, or streamStoragetypes that don't exist. There are no known cases where these are set wrongly by clients or the CLI, but it's generally better to have the server protect against invalid inputs.Signed-off-by: Maurice van Veen github@mauricevanveen.com