[IMPROVED] Recover TTL when enabled #7117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
neilalexander
added a commit
that referenced
this pull request
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling TTLs on a stream/source/mirror would not recover previous TTLs. TTLs can be enabled but not disabled, so it must be a conscious decision to enable it. Depending on the stream size, it might take a long time to recover but it will ensure all TTLs are respected.
This is important for a KV that's mirrored, because a mirrored KV might not have TTLs enabled yet, but the origin stream has. If you want the TTLs to be respected on the mirror as well, it needs to respect both new messages with TTLs as messages that it received prior.
Signed-off-by: Maurice van Veen github@mauricevanveen.com