Skip to content

[IMPROVED] NRG: remove StreamState usage in n.Applied and n.Size & async flush compacted tombstones #7109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2025
Merged

[IMPROVED] NRG: remove StreamState usage in n.Applied and n.Size & async flush compacted tombstones #7109

merged 3 commits into from
Jul 29, 2025

Conversation

MauriceVanVeen
Copy link
Member

Every call to n.Applied would result in calling n.wal.FastState, we can prevent this from happening by adding some additional tracking in the raft struct itself to not need to call out. The raft struct is now also aligned.

Any tombstones that need to be written as part of the Compact are now flushed async, similar to PurgeEx.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen
[IMPROVED] NRG: remove StreamState usage in n.Applied and n.Size
431a8b3 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen
[IMPROVED] Compact flushes tombstones less often
615feaa 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen
[IMPROVED] Raft struct alignment
6c33897 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner July 29, 2025 09:00
neilalexander
neilalexander approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 0f00b0d into main Jul 29, 2025
48 checks passed
@neilalexander neilalexander deleted the maurice/nrg-less-state branch July 29, 2025 10:12
@neilalexander neilalexander mentioned this pull request Jul 29, 2025
Merged
neilalexander added a commit that referenced this pull request Jul 29, 2025
@neilalexander
Cherry-picks for 2.11.7-RC.2 (#7115)
b3220a6 
Includes the following:

- Backported commit 12552e0 from #7018
- #7100 
- #7107
- #7109
- #7110
- #7111

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MauriceVanVeen @neilalexander