(2.12) [IMPROVED] Add account and user to client log #7079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61068c8 to
1bdb453
Compare
|
@MauriceVanVeen would it be possible to also include the user in the log line? |
Will add, would also resolve #4596 |
cd4303b to
ea61352
Compare
|
@MauriceVanVeen could you please rebase and let's merge it? |
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
ea61352 to
3af2c6c
Compare
neilalexander
added a commit
that referenced
this pull request
Aug 19, 2025
Since #7079 we have more detailed logging for clients. However, if the client was internal and had no string representation, it would log the following: ``` [WRN] - Invalid JetStream request '$G > $JS.API.STREAM.INFO.test-stream': <error> ``` The `" - "` prefix was due to this logging. This PR fixes that by not including it in this case. Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include client's account and user in any logs specific to a client connection, for example:
If many connections are created for the same account and above error is triggered, we now also rate-limit these logs (per account).
If there is an authentication error, the account will not be known, in that case only the user is logged.
Resolves #4596
Signed-off-by: Maurice van Veen github@mauricevanveen.com