Skip to content

[FIXED] Fix performance issue in firstMatchingMulti #7015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2025
Merged

[FIXED] Fix performance issue in firstMatchingMulti #7015

merged 1 commit into from
Jun 28, 2025

Conversation

neilalexander
Copy link
Member

We should only return that the cache can be expired if the start sequence is the end of the block, otherwise we will repeatedly load and expire the cache of the same block in LoadNextMsgMulti. This results in a noticeable slowdown.

Fixes #7014.

Signed-off-by: Neil Twigg neil@nats.io

@neilalexander neilalexander requested a review from a team as a code owner June 27, 2025 17:04
@neilalexander neilalexander mentioned this pull request Jun 27, 2025
Closed
@neilalexander neilalexander force-pushed the neil/firstmatchingmultiperf branch from 385b688 to 2793194 Compare June 27, 2025 17:09
@neilalexander
Fix performance issue in firstMatchingMulti
528de0c 
We should only return that the cache can be expired if the start sequence
is the end of the block, otherwise we will continously load and expire
the cache in `LoadNextMsgMulti`.

Fixes #7014.

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander force-pushed the neil/firstmatchingmultiperf branch from 2793194 to 528de0c Compare June 27, 2025 17:14
MauriceVanVeen
MauriceVanVeen approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 9d2e648 into main Jun 28, 2025
68 of 70 checks passed
@neilalexander neilalexander deleted the neil/firstmatchingmultiperf branch June 28, 2025 08:07
@neilalexander neilalexander mentioned this pull request Jun 30, 2025
Merged
@wallyqs wallyqs changed the title Fix performance issue in firstMatchingMulti [FIXED] Fix performance issue in firstMatchingMulti Jun 30, 2025
neilalexander added a commit that referenced this pull request Jun 30, 2025
@neilalexander
Cherry-picks for 2.11.6-RC.1 (#7023)
371321b 
Includes the following:

- #7013
- #7009
- #7008
- #7015
- #7019
- #7021
- #7022

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander mentioned this pull request Jul 2, 2025
Merged
neilalexander added a commit that referenced this pull request Jul 2, 2025
@neilalexander
Add BenchmarkJetStreamConsumeFilteredContiguous (#7031)
2ee2e24 
To avoid regressions after #7015, to be added into Gauge.

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MauriceVanVeen MauriceVanVeen MauriceVanVeen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JetStream Consumer Subject Filtering Causes 99% Performance Degradation
2 participants
@neilalexander @MauriceVanVeen