Skip to content

Include leaf node connections in connz #6949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

Include leaf node connections in connz #6949

merged 2 commits into from
Jun 6, 2025

Conversation

neilalexander
Copy link
Member

This worked if you used nats server report connections inside an account because we would automatically fill in Account in that case, and this worked if you specified Account because the account map included both clients and leafs, but the global s.clients map didn't so /connz or a system account request would omit s.leafs.

Fixes #6930.

Signed-off-by: Neil Twigg neil@nats.io

@neilalexander
Include leaf node connections in connz
3050b2d 
Fixes #6930.

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner June 6, 2025 15:16
derekcollison
derekcollison approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander
Fix TestMonitorConnzOperatorAccountNames
282e850 
Signed-off-by: Neil Twigg <neil@nats.io>
derekcollison
derekcollison approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 1151d51 into main Jun 6, 2025
68 of 70 checks passed
@neilalexander neilalexander deleted the neil/connzleafs branch June 6, 2025 15:53
@neilalexander neilalexander mentioned this pull request Jun 17, 2025
Merged
neilalexander added a commit that referenced this pull request Jun 17, 2025
@neilalexander
Cherry-picks for 2.11.5-RC.1 (#6985)
cd8f3f8 
Includes the following:

- #6922
- #6931
- #6933
- #6934
- #6939
- #6938
- #6940
- #6941
- #6942
- #6943
- #6945
- #6944
- #6947
- #6948
- #6949
- #6956
- #6960
- #6961
- #6951
- #6965
- #6968
- #6981
- #6983
- #6984

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leafnode CID/LID not shown in connection list
2 participants
@neilalexander @derekcollison