Check for DirectAllowed instead of DeleteAllowed #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Byron Ruth <byron@nats.io>
ripienaar
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
LGTM, other problems here too at present it makes a consumer to figure out start position. This isnt possible for WQ generally as there tend to be consumers.
So we'll have to deny view with any kind of since/etc parameters and only allow viewing from start. Will fix for next release.
|
Understood. I just happened to stumble upon that line when looking at an issue for a user. |
ripienaar
pushed a commit
to ripienaar/jsm.go
that referenced
this pull request
Mar 11, 2024
Signed-off-by: Byron Ruth <byron@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.