-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
docs: add example for module .with()
#32757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe documentation for the Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/3.api/5.kit/1.modules.md (2)
48-52
: Add a short prose intro before the overload snippet for discoverabilityThe new overload appears abruptly after the first declaration without any narrative to explain why it exists or when to prefer it. One-sentence context (e.g. “For cases where you need defaults to influence the resolved options type, use the following overload…”) will help readers who skim rather than read top-to-bottom.
131-173
: Clarify “optional” vs “always defined” in the.with()
exampleIn the inline comment you state that
timeout
andretries
are “Optional, has default value” yet also show their types as plainnumber
, implying they are always defined after resolution. This can confuse readers about the actual compile-time guarantee provided by.with()
.Replace the wording with something like “Always defined (default supplied)” to make the contract unambiguous, or explicitly show the post-merge type (
number
) contrasted with the pre-merge optional (number | undefined
).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/3.api/5.kit/1.modules.md
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: lint-docs
Co-authored-by: Damian Głowala <damian.glowala.rebkow@gmail.com>
🔗 Linked issue
📚 Description
This adds some basic docs for
.with
option introduced in #27520