fix(nuxt): execute all plugins after error rendering error.vue #32744

BobbieGoede · 2025-07-24T17:10:19Z

🔗 Linked issue

Plugin error is obfuscated by errors caused by skipped plugins #32743

📚 Description

Resolves #32743

This way the order of plugins won't break the setup of unrelated plugins.

bolt-new-by-stackblitz · 2025-07-24T17:10:22Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-07-24T17:12:21Z

Walkthrough

The changes update import paths for several internal Nuxt app types from relative paths using ../app/ to local paths using ./, reflecting a module reorganisation. In the applyPlugins function, the error handling logic is simplified by replacing an array-based collection of all plugin errors with a single error variable capturing the first encountered error. Parallel plugin promises are pushed without individual .catch handlers, while non-parallel plugins are awaited directly with conditional error rethrowing. After all plugins complete, if an error was captured, it is thrown with priority given to nuxtApp.payload.error if it exists.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 980a04f and 03570c5.

📒 Files selected for processing (1)

packages/nuxt/src/app/nuxt.ts (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/nuxt/src/app/nuxt.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: build
GitHub Check: code

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-07-24T17:14:08Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32744

nuxt

npm i https://pkg.pr.new/nuxt@32744

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32744

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32744

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32744

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32744

commit: 03570c5

codspeed-hq · 2025-07-24T17:25:29Z

CodSpeed Performance Report

Merging #32744 will not alter performance

_{Comparing BobbieGoede:fix/keep-executing-plugins-after-plugin-failure (03570c5) with main (7f11348)}

Summary

✅ 10 untouched benchmarks

danielroe

This makes sense to me. I think originally this might have been because we wanted to avoid other plugins erroring if they depended on the broken original plugin.

... but as we are already handling an array of errors, I think it makes sense.

maybe we could even move the .catch to where the promise is defined to avoid duplicating on L448

BobbieGoede · 2025-07-25T08:34:34Z

maybe we could even move the .catch to where the promise is defined to avoid duplicating on L448

Done!

This makes sense to me. I think originally this might have been because we wanted to avoid other plugins erroring if they depended on the broken original plugin.
... but as we are already handling an array of errors, I think it makes sense.

We're collecting errors in an array but only throwing the first error on L474, do we plan to make those other errors visible someday? Hiding the errors from plugins depending on a broken plugin makes sense to me though, but (with this change) it's possible unrelated plugins will error too.

danielroe

what about we only short-circuit running the plugins if we aren't rendering an error page?

packages/nuxt/src/app/nuxt.ts

…ugins-after-plugin-failure

danielroe · 2025-07-28T21:43:35Z

sorry for the back and forth! 🤦

hopefully this is still good!

BobbieGoede · 2025-07-29T11:07:04Z

packages/nuxt/src/app/nuxt.ts

+      }).catch((e) => {
+        // short circuit if we are not rendering `error.vue`
+        if (!plugin.parallel && !nuxtApp.payload.error) {
+          throw error


@danielroe
This should probably be throw e, right? 👀

fix: execute plugins after plugin failure

9ba4ee4

BobbieGoede requested a review from danielroe as a code owner July 24, 2025 17:10

github-actions bot added 4.x bug labels Jul 24, 2025

BobbieGoede changed the title ~~fix: execute plugins after plugin failure~~ fix(nuxt): execute plugins after plugin failure Jul 24, 2025

BobbieGoede mentioned this pull request Jul 24, 2025

Nuxt error page with layout throws vague error _ctx.$myPluginMethod is not a function vuejs/vuefire#1633

Closed

danielroe requested review from TheAlexLichter and huang-julien July 25, 2025 07:47

danielroe reviewed Jul 25, 2025

View reviewed changes

BobbieGoede added 2 commits July 25, 2025 10:18

refactor: avoid duplicate catch

4cd41c8

Merge branch 'main' into fix/keep-executing-plugins-after-plugin-failure

64f0202

danielroe reviewed Jul 25, 2025

View reviewed changes

BobbieGoede added 2 commits July 25, 2025 12:03

fix: short-circuit when not rendering error page

16b78a8

Merge branch 'main' into fix/keep-executing-plugins-after-plugin-failure

0216a92

BobbieGoede commented Jul 25, 2025

View reviewed changes

packages/nuxt/src/app/nuxt.ts Outdated Show resolved Hide resolved

danielroe added 2 commits July 28, 2025 16:17

Merge remote-tracking branch 'origin/main' into fix/keep-executing-pl…

8bbe7a7

…ugins-after-plugin-failure

refactor: move logic into catch block

4c0a18c

danielroe force-pushed the fix/keep-executing-plugins-after-plugin-failure branch from 2afd278 to 4c0a18c Compare July 28, 2025 16:23

danielroe approved these changes Jul 28, 2025

View reviewed changes

huang-julien approved these changes Jul 28, 2025

View reviewed changes

fix: always throw root error

980a04f

danielroe changed the title ~~fix(nuxt): execute plugins after plugin failure~~ fix(nuxt): always throw first error when rendering error page Jul 28, 2025

perf: ensure we short circuit plugins when not rendering error page

03570c5

danielroe changed the title ~~fix(nuxt): always throw first error when rendering error page~~ fix(nuxt): execute all plugins after error rendering error.vue Jul 28, 2025

danielroe merged commit 7831bee into nuxt:main Jul 28, 2025
82 of 84 checks passed

github-actions bot mentioned this pull request Jul 28, 2025

v4.0.2 #32710

Merged

danielroe pushed a commit that referenced this pull request Jul 28, 2025

fix(nuxt): execute all plugins after error rendering error.vue (#32744)

71c3377

github-actions bot mentioned this pull request Jul 28, 2025

v3.18.0 #32713

Merged

BobbieGoede commented Jul 29, 2025

View reviewed changes

BobbieGoede mentioned this pull request Jul 29, 2025

fix(nuxt): throwing undefined error variable #32807

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(nuxt): execute all plugins after error rendering error.vue #32744

fix(nuxt): execute all plugins after error rendering error.vue #32744

BobbieGoede commented Jul 24, 2025

Uh oh!

bolt-new-by-stackblitz bot commented Jul 24, 2025

Uh oh!

coderabbitai bot commented Jul 24, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jul 24, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jul 24, 2025 •

edited

Loading

Uh oh!

danielroe left a comment

Uh oh!

BobbieGoede commented Jul 25, 2025 •

edited

Loading

Uh oh!

danielroe left a comment

Uh oh!

Uh oh!

danielroe commented Jul 28, 2025

Uh oh!

Uh oh!

BobbieGoede Jul 29, 2025

Uh oh!

Uh oh!

Uh oh!

fix(nuxt): execute all plugins after error rendering error.vue #32744

fix(nuxt): execute all plugins after error rendering error.vue #32744

Conversation

BobbieGoede commented Jul 24, 2025

🔗 Linked issue

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented Jul 24, 2025

Uh oh!

coderabbitai bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #32744 will not alter performance

Summary

Uh oh!

danielroe left a comment

Choose a reason for hiding this comment

Uh oh!

BobbieGoede commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danielroe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

danielroe commented Jul 28, 2025

Uh oh!

Uh oh!

BobbieGoede Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot commented Jul 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented Jul 24, 2025 •

edited

Loading

codspeed-hq bot commented Jul 24, 2025 •

edited

Loading

BobbieGoede commented Jul 25, 2025 •

edited

Loading