refactor(nuxt): pass file language directly to parser options #32665

cernymatej · 2025-07-17T23:38:27Z

🔗 Linked issue

fixes #32663

📚 Description

This follows up on the changes in oxc-project/oxc-walker#110 to make the language specification more robust / cleaner.

bolt-new-by-stackblitz · 2025-07-17T23:38:30Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-07-17T23:42:49Z

Walkthrough

The update enhances the typing and parsing behaviour within the code handling macro queries and transformation. The parseMacroQuery function now uses a generic type that allows for an optional lang property, making the source code language explicit in the parsed query. In the transform function, the parser is now provided with a parseOptions object containing the language, defaulting to 'ts' if unspecified, and the file identifier is passed directly without modification. No changes were made to exported or public entity signatures; all adjustments are internal.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b661a5 and c5747ef.

📒 Files selected for processing (1)

packages/nuxt/src/pages/plugins/page-meta.ts (4 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{ts,tsx}

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

.github/copilot-instructions.md

**/*.{ts,tsx,vue}

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

.github/copilot-instructions.md

🧠 Learnings (2)

📓 Common learnings

Learnt from: Tofandel
PR: nuxt/nuxt#0
File: :0-0
Timestamp: 2024-11-11T12:34:22.648Z
Learning: Ensure that AI-generated summaries accurately reflect the key changes in the PR, focusing on notable changes such as the removal of unused imports and variables starting with underscores.

Learnt from: GalacticHypernova
PR: nuxt/nuxt#29661
File: packages/kit/src/template.ts:227-229
Timestamp: 2024-11-28T21:22:40.496Z
Learning: In `packages/kit/src/template.ts`, when updating the `EXTENSION_RE` regular expression for TypeScript configuration, avoid using patterns like `(\.\w+)+$` as they can result in catastrophic backtracking.

packages/nuxt/src/pages/plugins/page-meta.ts (2)

Learnt from: Tofandel
PR: nuxt/nuxt#0
File: :0-0
Timestamp: 2024-11-11T12:34:22.648Z
Learning: Ensure that AI-generated summaries accurately reflect the key changes in the PR, focusing on notable changes such as the removal of unused imports and variables starting with underscores.

Learnt from: GalacticHypernova
PR: nuxt/nuxt#26468
File: packages/nuxt/src/components/plugins/loader.ts:24-24
Timestamp: 2024-11-05T15:22:54.759Z
Learning: In `packages/nuxt/src/components/plugins/loader.ts`, the references to `resolve` and `distDir` are legacy code from before Nuxt used the new unplugin VFS and will be removed.

🪛 GitHub Check: build

packages/nuxt/src/pages/plugins/page-meta.ts

[failure] 219-219:
No overload matches this call.

🪛 GitHub Actions: ci

packages/nuxt/src/pages/plugins/page-meta.ts

[error] 219-219: TypeScript error TS2769: No overload matches this call.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: code

🔇 Additional comments (3)

packages/nuxt/src/pages/plugins/page-meta.ts (3)

4-4: LGTM! Import addition supports enhanced typing.

The ParsedQuery import is correctly added to support the generic typing enhancement in the parseMacroQuery function.

21-21: LGTM! Import supports parser options typing.

The ParserOptions import is correctly added to provide proper typing for the lang property in the enhanced query parsing.

351-353: Excellent typing enhancement for language specification.

The generic type enhancement properly extends ParsedQuery with an optional lang property, improving type safety and making language specification explicit. This aligns perfectly with the PR objective of enhancing language handling robustness.

packages/nuxt/src/pages/plugins/page-meta.ts

socket-security · 2025-07-18T11:05:24Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	std-env@3.9.0
	pathe@2.0.3
	jiti@2.4.2
	semver@7.7.2
	tinyglobby@0.2.14

View full report

pkg-pr-new · 2025-07-18T11:11:04Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32665

nuxt

npm i https://pkg.pr.new/nuxt@32665

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32665

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32665

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32665

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32665

commit: 66d0ef4

codspeed-hq · 2025-07-18T11:23:07Z

CodSpeed Performance Report

Merging #32665 will not alter performance

_{Comparing cernymatej:fix/page-meta-extraction (66d0ef4) with main (3b661a5)}

Summary

✅ 10 untouched benchmarks

danielroe

❤️

refactor(nuxt): pass file language directly to parser options

c5747ef

cernymatej requested a review from danielroe as a code owner July 17, 2025 23:38

github-actions bot added 4.x refactor labels Jul 17, 2025

coderabbitai bot reviewed Jul 17, 2025

View reviewed changes

packages/nuxt/src/pages/plugins/page-meta.ts Show resolved Hide resolved

chore(deps): update oxc-walker to 4.0.0

eb401fa

chore(deps): undo package-lock changes

66d0ef4

danielroe approved these changes Jul 18, 2025

View reviewed changes

danielroe merged commit a6bc840 into nuxt:main Jul 18, 2025
84 of 86 checks passed

This was referenced Jul 17, 2025

v4.0.1 #32641

Merged

v4.0.1 #32705

Closed

danielroe pushed a commit that referenced this pull request Jul 21, 2025

refactor(nuxt): pass file language directly to parser options (#32665)

fb87c00

This was referenced Jul 21, 2025

v3.17.8 #32610

Closed

v3.18.0 #32713

Merged

cernymatej deleted the fix/page-meta-extraction branch July 23, 2025 16:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(nuxt): pass file language directly to parser options #32665

refactor(nuxt): pass file language directly to parser options #32665

Uh oh!

cernymatej commented Jul 17, 2025 •

edited

Loading

Uh oh!

bolt-new-by-stackblitz bot commented Jul 17, 2025

Uh oh!

coderabbitai bot commented Jul 17, 2025

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

socket-security bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jul 18, 2025

Uh oh!

codspeed-hq bot commented Jul 18, 2025

Uh oh!

danielroe left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

refactor(nuxt): pass file language directly to parser options #32665

refactor(nuxt): pass file language directly to parser options #32665

Uh oh!

Conversation

cernymatej commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Linked issue

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented Jul 17, 2025

Uh oh!

coderabbitai bot commented Jul 17, 2025

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

socket-security bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Jul 18, 2025

Uh oh!

codspeed-hq bot commented Jul 18, 2025

CodSpeed Performance Report

Merging #32665 will not alter performance

Summary

Uh oh!

danielroe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cernymatej commented Jul 17, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

socket-security bot commented Jul 18, 2025 •

edited

Loading