-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
docs: added new Shared folder to the example of v4 folder structure #32630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the shared/ folder was missing from the v4 folder structure example
|
WalkthroughThe documentation describing the Nuxt 4 directory structure has been updated to mention the inclusion of a new shared/ directory at the root level. This update clarifies that shared/ is now part of the default project directory layout, listed alongside existing directories such as layers/, modules/, node_modules/, public/, and server/. No changes have been made to exported or public entity declarations. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/1.getting-started/18.upgrade.md (1)
141-145
: Add matching bullet so the documentation stays internally consistentThe example tree now shows
shared/
, but the explanatory bullet list above (lines 113-118) still omits it. Readers may miss the new folder unless both sections align.@@ -* `layers/`, `modules/` and `public/` are resolved relative to `<rootDir>` by default +* `layers/`, `modules/`, `public/` **and `shared/`** are resolved relative to `<rootDir>` by default
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/1.getting-started/18.upgrade.md
(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: GalacticHypernova
PR: nuxt/nuxt#26468
File: packages/nuxt/src/components/plugins/loader.ts:24-24
Timestamp: 2024-11-05T15:22:54.759Z
Learning: In `packages/nuxt/src/components/plugins/loader.ts`, the references to `resolve` and `distDir` are legacy code from before Nuxt used the new unplugin VFS and will be removed.
docs/1.getting-started/18.upgrade.md (1)
Learnt from: GalacticHypernova
PR: nuxt/nuxt#26468
File: packages/nuxt/src/components/plugins/loader.ts:24-24
Timestamp: 2024-11-05T15:22:54.759Z
Learning: In `packages/nuxt/src/components/plugins/loader.ts`, the references to `resolve` and `distDir` are legacy code from before Nuxt used the new unplugin VFS and will be removed.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: lint-docs
📚 Description
new
shared/
folder was not shown on the example of v4 folder structure https://nuxt.com/docs/4.x/getting-started/upgrade