Skip to content

feat(nuxt): expose page routes to nitro for o11y #32617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 15, 2025
Merged

Conversation

danielroe
Copy link
Member

🔗 Linked issue

nitrojs/nitro#3475

📚 Description

this adds an implementation of nitro's new ssrRoutes option, allowing paths registered by vue router to be exposed to server observability handling

@danielroe danielroe requested a review from pi0 July 14, 2025 22:23
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

coderabbitai bot commented Jul 14, 2025

Walkthrough

The changes introduce a new utility function, toRou3Patterns, which converts Nuxt page definitions into rou3-compatible route patterns. This function is integrated into the Nuxt module's nitro:build:before hook to extend the server-side rendered routes before the Nitro build, conditional on the app not being in development mode and router hash mode being disabled. A new test suite is added to verify SSR route generation using this utility. Additionally, the page route generation test data is refactored into exported constants for modularity and reuse across test files. No modifications are made to existing public or exported entity signatures besides the addition of new exports.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ceb9281 and 425360e.

📒 Files selected for processing (2)
  • packages/nuxt/src/pages/utils.ts (1 hunks)
  • packages/nuxt/test/nitro-ssr-routes.test.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/nuxt/test/nitro-ssr-routes.test.ts
  • packages/nuxt/src/pages/utils.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: codeql (javascript-typescript)
  • GitHub Check: build
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/ssr-routes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Jul 14, 2025

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32617

nuxt

npm i https://pkg.pr.new/nuxt@32617

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32617

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32617

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32617

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32617

commit: 1980ae1

Copy link

codspeed-hq bot commented Jul 14, 2025

CodSpeed Performance Report

Merging #32617 will not alter performance

Comparing feat/ssr-routes (1980ae1) with main (97386a0)

Summary

✅ 10 untouched benchmarks

@danielroe danielroe merged commit a450079 into main Jul 15, 2025
80 of 83 checks passed
@danielroe danielroe deleted the feat/ssr-routes branch July 15, 2025 18:58
@github-actions github-actions bot mentioned this pull request Jul 15, 2025
@github-actions github-actions bot mentioned this pull request Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant