-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
docs: add section about module loading order #32597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughA new section was added to the upgrade guide documentation, detailing a correction to the module loading order in Nuxt layers. The documentation explains that modules from extended layers are now loaded before modules from the project root, with the project modules having the highest priority. This adjustment affects both modules listed in the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/1.getting-started/18.upgrade.md (2)
334-338
: Insert missing article for clarityThe phrase “depend on specific loading order” reads a little abruptly. Adding the article “a” makes the sentence smoother and grammatically correct.
-1. **Review module dependencies**: Check if any modules depend on specific loading order +1. **Review module dependencies**: Check if any modules depend on a specific loading order
312-314
: Tighten punctuation – remove extra space after the periodThere is a double space before “Now” which breaks consistency in spacing.
-...reverse of the expected behavior. Now modules are loaded in the correct order: +...reverse of the expected behavior. Now modules are loaded in the correct order:
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/1.getting-started/18.upgrade.md
(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: GalacticHypernova
PR: nuxt/nuxt#26468
File: packages/nuxt/src/components/plugins/loader.ts:24-24
Timestamp: 2024-11-05T15:22:54.759Z
Learning: In `packages/nuxt/src/components/plugins/loader.ts`, the references to `resolve` and `distDir` are legacy code from before Nuxt used the new unplugin VFS and will be removed.
docs/1.getting-started/18.upgrade.md (3)
Learnt from: GalacticHypernova
PR: nuxt/nuxt#26468
File: packages/nuxt/src/components/plugins/loader.ts:24-24
Timestamp: 2024-11-05T15:22:54.759Z
Learning: In `packages/nuxt/src/components/plugins/loader.ts`, the references to `resolve` and `distDir` are legacy code from before Nuxt used the new unplugin VFS and will be removed.
Learnt from: Tofandel
PR: nuxt/nuxt#0
File: :0-0
Timestamp: 2024-11-11T12:34:22.648Z
Learning: Ensure that AI-generated summaries accurately reflect the key changes in the PR, focusing on notable changes such as the removal of unused imports and variables starting with underscores.
Learnt from: huang-julien
PR: nuxt/nuxt#29366
File: packages/nuxt/src/app/components/nuxt-root.vue:16-19
Timestamp: 2024-12-12T12:36:34.871Z
Learning: In `packages/nuxt/src/app/components/nuxt-root.vue`, when optimizing bundle size by conditionally importing components based on route metadata, prefer using inline conditional imports like:
```js
const IsolatedPage = route?.meta?.isolate ? defineAsyncComponent(() => import('#build/isolated-page.mjs')) : null
```
instead of wrapping the import in a computed property or importing the component unconditionally.
🪛 LanguageTool
docs/1.getting-started/18.upgrade.md
[uncategorized] ~313-~313: Possible missing comma found.
Context: ... the reverse of the expected behavior. Now modules are loaded in the correct order...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~336-~336: Possible missing article found.
Context: ...ncies**: Check if any modules depend on specific loading order 2. **Adjust module config...
(AI_HYDRA_LEO_MISSING_A)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: lint-docs
- GitHub Check: link-checker
- GitHub Check: lint-docs
🔗 Linked issue
📚 Description
this follows up on #31507 to describe the change that's taken place