fix(kit): do not skip layer with defined `srcDir` #32487

danielroe · 2025-06-27T08:06:50Z

🔗 Linked issue

📚 Description

regression in #32343

bolt-new-by-stackblitz · 2025-06-27T08:06:53Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-06-27T08:08:09Z

Walkthrough

The change modifies a conditional statement within the _generateTypes function in the template.ts file. The previous logic checked if the source directory or current working directory did not start with the root directory with a trailing slash, was exactly equal to the root directory with a trailing slash, or included 'node_modules'. The updated logic now checks if the source directory or current working directory does not start with the root directory with a trailing slash, if the layer's current working directory is exactly equal to the root directory (without a trailing slash), or if 'node_modules' is included in the path. No changes were made to exported or public entity declarations.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d680c3f and 8b55842.

📒 Files selected for processing (1)

packages/kit/src/template.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.ts`: Follow standard TypeScript conventions and best practices

**/*.ts: Follow standard TypeScript conventions and best practices

📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)

List of files the instruction was applied to:

packages/kit/src/template.ts

🧠 Learnings (2)

📓 Common learnings

Learnt from: GalacticHypernova
PR: nuxt/nuxt#29661
File: packages/kit/src/template.ts:227-229
Timestamp: 2024-11-28T21:22:40.496Z
Learning: In `packages/kit/src/template.ts`, when updating the `EXTENSION_RE` regular expression for TypeScript configuration, avoid using patterns like `(\.\w+)+$` as they can result in catastrophic backtracking.

Learnt from: GalacticHypernova
PR: nuxt/nuxt#26468
File: packages/nuxt/src/components/plugins/loader.ts:24-24
Timestamp: 2024-11-05T15:22:54.759Z
Learning: In `packages/nuxt/src/components/plugins/loader.ts`, the references to `resolve` and `distDir` are legacy code from before Nuxt used the new unplugin VFS and will be removed.

Learnt from: huang-julien
PR: nuxt/nuxt#29366
File: packages/nuxt/src/app/components/nuxt-root.vue:16-19
Timestamp: 2024-12-12T12:36:34.871Z
Learning: In `packages/nuxt/src/app/components/nuxt-root.vue`, when optimizing bundle size by conditionally importing components based on route metadata, prefer using inline conditional imports like:

```js
const IsolatedPage = route?.meta?.isolate ? defineAsyncComponent(() => import('#build/isolated-page.mjs')) : null
```

instead of wrapping the import in a computed property or importing the component unconditionally.

packages/kit/src/template.ts (4)

Learnt from: GalacticHypernova
PR: nuxt/nuxt#29661
File: packages/kit/src/template.ts:227-229
Timestamp: 2024-11-28T21:22:40.496Z
Learning: In `packages/kit/src/template.ts`, when updating the `EXTENSION_RE` regular expression for TypeScript configuration, avoid using patterns like `(\.\w+)+$` as they can result in catastrophic backtracking.

Learnt from: Tofandel
PR: nuxt/nuxt#0
File: :0-0
Timestamp: 2024-11-11T12:34:22.648Z
Learning: Ensure that AI-generated summaries accurately reflect the key changes in the PR, focusing on notable changes such as the removal of unused imports and variables starting with underscores.

Learnt from: GalacticHypernova
PR: nuxt/nuxt#26468
File: packages/nuxt/src/components/plugins/loader.ts:24-24
Timestamp: 2024-11-05T15:22:54.759Z
Learning: In `packages/nuxt/src/components/plugins/loader.ts`, the references to `resolve` and `distDir` are legacy code from before Nuxt used the new unplugin VFS and will be removed.

Learnt from: huang-julien
PR: nuxt/nuxt#29366
File: packages/nuxt/src/app/components/nuxt-root.vue:16-19
Timestamp: 2024-12-12T12:36:34.871Z
Learning: In `packages/nuxt/src/app/components/nuxt-root.vue`, when optimizing bundle size by conditionally importing components based on route metadata, prefer using inline conditional imports like:

```js
const IsolatedPage = route?.meta?.isolate ? defineAsyncComponent(() => import('#build/isolated-page.mjs')) : null
```

instead of wrapping the import in a computed property or importing the component unconditionally.

🔇 Additional comments (1)

packages/kit/src/template.ts (1)

212-212: LGTM! This correctly fixes the regression with custom srcDir layers.

The change from srcOrCwd === rootDirWithSlash to layer.cwd === nuxt.options.rootDir properly addresses the issue where layers with custom srcDir were being incorrectly filtered out. The new logic correctly checks whether the layer's actual directory (layer.cwd) is at the root, rather than checking if the layer's configured source directory (srcOrCwd) happens to match the root path. This ensures that layers with custom srcDir configurations are properly included in type generation.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate Unit Tests

Create PR with Unit Tests
Post Copyable Unit Tests in Comment
Commit Unit Tests in branch fix/root-dir-types

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-06-27T08:14:12Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32487

nuxt

npm i https://pkg.pr.new/nuxt@32487

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32487

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32487

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32487

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32487

commit: 8b55842

codspeed-hq · 2025-06-27T08:25:48Z

CodSpeed Performance Report

Merging #32487 will not alter performance

_{Comparing fix/root-dir-types (8b55842) with main (d680c3f)}

Summary

✅ 10 untouched benchmarks

fix(kit): do not skip layer with custom srcDir

8b55842

danielroe changed the title ~~fix(kit): do not skip layer with custom srcDir~~ fix(kit): do not skip layer with defined srcDir Jun 27, 2025

github-actions bot added 4.x bug labels Jun 27, 2025

danielroe merged commit b517c41 into main Jun 27, 2025
84 of 85 checks passed

danielroe deleted the fix/root-dir-types branch June 27, 2025 09:17

github-actions bot mentioned this pull request Jun 27, 2025

v4.0.0 #27716

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(kit): do not skip layer with defined `srcDir` #32487

fix(kit): do not skip layer with defined `srcDir` #32487

Uh oh!

danielroe commented Jun 27, 2025

Uh oh!

bolt-new-by-stackblitz bot commented Jun 27, 2025

Uh oh!

coderabbitai bot commented Jun 27, 2025

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jun 27, 2025

Uh oh!

codspeed-hq bot commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix(kit): do not skip layer with defined srcDir #32487

fix(kit): do not skip layer with defined srcDir #32487

Uh oh!

Conversation

danielroe commented Jun 27, 2025

🔗 Linked issue

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented Jun 27, 2025

Uh oh!

coderabbitai bot commented Jun 27, 2025

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jun 27, 2025

Uh oh!

codspeed-hq bot commented Jun 27, 2025

CodSpeed Performance Report

Merging #32487 will not alter performance

Summary

Uh oh!

Uh oh!

Uh oh!

fix(kit): do not skip layer with defined `srcDir` #32487

fix(kit): do not skip layer with defined `srcDir` #32487

CodeRabbit Configuration File (`.coderabbit.yaml`)