-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
chore: mention bun.lock
for lockfile
#32427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: mention bun.lock
for lockfile
#32427
Conversation
|
WalkthroughThe changes update both documentation and core logic to include the ✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
docs/2.guide/3.going-further/11.nightly-release-channel.md (2)
35-35
: Minor wording nit: pluralise “lockfile”.Since the sentence lists multiple files, consider changing “lockfile” → “lockfiles” for grammatical accuracy.
-Remove lockfile (`package-lock.json`, `yarn.lock`, `pnpm-lock.yaml`, `bun.lock` or `bun.lockb`) and reinstall dependencies. +Remove lockfiles (`package-lock.json`, `yarn.lock`, `pnpm-lock.yaml`, `bun.lock` or `bun.lockb`) and reinstall dependencies.
50-50
: Apply the same pluralisation nit here for consistency.-Remove lockfile (`package-lock.json`, `yarn.lock`, `pnpm-lock.yaml`, `bun.lock` or `bun.lockb`) and reinstall dependencies. +Remove lockfiles (`package-lock.json`, `yarn.lock`, `pnpm-lock.yaml`, `bun.lock` or `bun.lockb`) and reinstall dependencies.docs/2.guide/3.going-further/1.experimental-features.md (1)
387-391
: Alphabetical order: keep the list tidy.To keep the lockfile list readable, add
bun.lock
afterbun.lockb
or sort the whole block alphabetically.tsconfig.json bun.lockb bun.lock
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
docs/2.guide/3.going-further/1.experimental-features.md
(1 hunks)docs/2.guide/3.going-further/11.nightly-release-channel.md
(2 hunks)packages/nuxt/src/core/cache.ts
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: lint-docs
- GitHub Check: codeql (javascript-typescript)
- GitHub Check: codeql (actions)
- GitHub Check: build
- GitHub Check: code
🔇 Additional comments (1)
packages/nuxt/src/core/cache.ts (1)
139-148
: Consistency check: make sure every lockfile list now includesbun.lock
.
bun.lock
is correctly added here, but other code-paths or utility helpers might still only referencebun.lockb
. A quick search across the repo forbun.lockb
without a neighbouringbun.lock
will highlight any omissions.#!/usr/bin/env bash # Find occurrences of 'bun.lockb' that are not accompanied by 'bun.lock' rg --line-number --context 2 $'bun\\.lockb' | grep -v 'bun\\.lock'If the script prints anything, those files should probably be updated for parity.
@nuxt/kit
nuxt
@nuxt/rspack-builder
@nuxt/schema
@nuxt/vite-builder
@nuxt/webpack-builder
commit: |
Thanks @danielroe . 😊 |
CodSpeed Performance ReportMerging #32427 will not alter performanceComparing Summary
|
bun generates
bun.lock
by default from bun v1.2. That is why I think may be here we may addbun.lock
withbun.lockb
as well.https://bun.sh/docs/install/lockfile