fix(nuxt): pass `output.generatedCode.symbols: true` to nitro for rolldown-vite #32358

sapphi-red · 2025-06-11T04:29:20Z

🔗 Linked issue

📚 Description

Rolldown currently does not inline dynamic imports that imports statically imported modules (rolldown/rolldown#4905). This is the feature in rollup that requires Nuxt to set output.generatedCode.symbols: true as a workaround for vuejs/core#8351.

Because Rolldown does not inline dynamic imports, Nitro (which uses Rollup) sees that and inlines them. However, since output.generatedCode.symbols: true is not set for Nitro's Rollup build, the generated code encounters vuejs/core#8351. This leads to a test failure due to an import error on server side for this component:

nuxt/test/fixtures/basic/app/pages/lazy-import-components/index.vue

Line 4 in 017d1be

Because I didn't find any problems with setting output.generatedCode.symbols: true for normal Vite, I've added it unconditionally.

…ldown-vite

bolt-new-by-stackblitz · 2025-06-11T04:29:23Z

Run & review this pull request in StackBlitz Codeflow.

pkg-pr-new · 2025-06-11T04:32:54Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32358

nuxt

npm i https://pkg.pr.new/nuxt@32358

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32358

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32358

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32358

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32358

commit: 818fac1

codspeed-hq · 2025-06-11T04:43:28Z

CodSpeed Performance Report

Merging #32358 will not alter performance

_{Comparing sapphi-red:fix/nuxt-pass-output-generatedcode-symbols-true-for-rolldown-vite (818fac1) with main (4b56bb9)}

Summary

✅ 10 untouched benchmarks

coderabbitai · 2025-06-11T04:46:13Z

Walkthrough

The change updates the rollupConfig.output property within the initNitro function in the Nitro configuration. Instead of an empty object, rollupConfig.output now includes a generatedCode object with symbols: true as a property. This modification is noted as a temporary workaround for a specific issue in Vue.js core. No other aspects of the code, including logic or public API declarations, are affected by this update.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5afa30b and 818fac1.

📒 Files selected for processing (1)

packages/nuxt/src/core/nitro.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/nuxt/src/core/nitro.ts

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: code
GitHub Check: codeql (actions)
GitHub Check: codeql (javascript-typescript)
GitHub Check: build

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate Unit Tests

Create PR with Unit Tests
Commit Unit Tests in branch fix/nuxt-pass-output-generatedcode-symbols-true-for-rolldown-vite
Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/nuxt/src/core/nitro.ts (1)

239-246: Add test for dynamic import workaround

You've introduced output.generatedCode.symbols: true to fix dynamic import resolution per Vue core issue #8351. To guard against future regressions, please add an integration test or fixture that verifies dynamic imports of statically imported modules now load correctly on the server. I’m happy to help draft this test.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 017d1be and 5afa30b.

📒 Files selected for processing (1)

packages/nuxt/src/core/nitro.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: test-fixtures (windows-latest, built, webpack, async, manifest-on, json, 20)
GitHub Check: test-fixtures (windows-latest, built, rspack, default, manifest-on, json, 20)
GitHub Check: test-fixtures (windows-latest, built, rspack, async, manifest-on, json, 20)
GitHub Check: test-fixtures (windows-latest, built, vite, async, manifest-off, json, 20)
GitHub Check: test-fixtures (windows-latest, dev, vite, default, manifest-off, json, 20)
GitHub Check: test-fixtures (windows-latest, built, vite, default, manifest-off, json, 20)

packages/nuxt/src/core/nitro.ts

Co-authored-by: Alexander Lichter <github@lichter.io>

SergkeiM · 2025-06-26T17:06:54Z

I tried using this solution but still SSR is broken when using cloudflare-module nitro preset

sapphi-red · 2025-06-27T03:58:36Z

I guess it's vitejs/rolldown-vite#248

SergkeiM · 2025-06-27T06:45:12Z

Hi @sapphi-red can you point me to a direction how to apply neutral platform when building nuxt?

fix(nuxt): pass output.generatedCode.symbols: true to nitro for rol…

5afa30b

…ldown-vite

github-actions bot added 4.x bug labels Jun 11, 2025

sapphi-red marked this pull request as ready for review June 11, 2025 04:44

sapphi-red requested a review from danielroe as a code owner June 11, 2025 04:44

coderabbitai bot reviewed Jun 11, 2025

View reviewed changes

TheAlexLichter reviewed Jun 12, 2025

View reviewed changes

packages/nuxt/src/core/nitro.ts Outdated Show resolved Hide resolved

chore: update comment

818fac1

Co-authored-by: Alexander Lichter <github@lichter.io>

danielroe approved these changes Jun 14, 2025

View reviewed changes

danielroe merged commit 828e0e5 into nuxt:main Jun 14, 2025
46 checks passed

github-actions bot mentioned this pull request Jun 14, 2025

v4.0.0 #27716

Merged

sapphi-red deleted the fix/nuxt-pass-output-generatedcode-symbols-true-for-rolldown-vite branch June 27, 2025 03:58

danielroe pushed a commit that referenced this pull request Jul 1, 2025

fix(nuxt): set output.generatedCode.symbols for nitro build (#32358)

58f1a2b

github-actions bot mentioned this pull request Jul 1, 2025

v3.17.6 #32346

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(nuxt): pass `output.generatedCode.symbols: true` to nitro for rolldown-vite #32358

fix(nuxt): pass `output.generatedCode.symbols: true` to nitro for rolldown-vite #32358

Uh oh!

sapphi-red commented Jun 11, 2025 •

edited

Loading

Uh oh!

bolt-new-by-stackblitz bot commented Jun 11, 2025

Uh oh!

pkg-pr-new bot commented Jun 11, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jun 11, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 11, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

SergkeiM commented Jun 26, 2025

Uh oh!

sapphi-red commented Jun 27, 2025

Uh oh!

SergkeiM commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

fix(nuxt): pass output.generatedCode.symbols: true to nitro for rolldown-vite #32358

fix(nuxt): pass output.generatedCode.symbols: true to nitro for rolldown-vite #32358

Uh oh!

Conversation

sapphi-red commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Linked issue

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented Jun 11, 2025

Uh oh!

pkg-pr-new bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #32358 will not alter performance

Summary

Uh oh!

coderabbitai bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SergkeiM commented Jun 26, 2025

Uh oh!

sapphi-red commented Jun 27, 2025

Uh oh!

SergkeiM commented Jun 27, 2025

Uh oh!

Uh oh!

fix(nuxt): pass `output.generatedCode.symbols: true` to nitro for rolldown-vite #32358

fix(nuxt): pass `output.generatedCode.symbols: true` to nitro for rolldown-vite #32358

sapphi-red commented Jun 11, 2025 •

edited

Loading

pkg-pr-new bot commented Jun 11, 2025 •

edited

Loading

codspeed-hq bot commented Jun 11, 2025 •

edited

Loading

coderabbitai bot commented Jun 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)