chore(ui-templates): new templates branding for v4 #27843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
We need a pay to get the version (major + minor) from the package.json somehow @danielroe, I let you take a look at it |
danielroe
reviewed
Jun 27, 2024
| if (typeof window.fetch === 'undefined') { | ||
| setTimeout(() => window.location.reload(), 1000) | ||
| setTimeout(() => window.location.reload(), 200) |
There was a problem hiding this comment.
I've reduced the reload amount to 200ms - seem ok?
Merged
danielroe
pushed a commit
that referenced
this pull request
Jun 29, 2024
Kamsou
pushed a commit
to Kamsou/nuxt
that referenced
this pull request
Feb 5, 2025
|
@atinux Why you use 2 separate grid insted 1 grid with ul > li clear semantic list of links? |
|
improvements welcome! 🙏 |
|
Agree, feel free to make a PR if you find better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26959
CleanShot.2024-06-26.at.15.29.40.mp4
CleanShot.2024-06-26.at.15.29.54.mp4
I know it does not resolve all the comments from the issue, but this is a good start IMO for future iterations.