Skip to content

fix(nuxt): don't strip literals from template in <DevOnly> #24511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 28, 2023
Merged

fix(nuxt): don't strip literals from template in <DevOnly> #24511

merged 6 commits into from
Nov 28, 2023

Conversation

huang-julien
Copy link
Member

@huang-julien huang-julien commented Nov 28, 2023 •
edited
Loading

🔗 Linked issue

fix #24491

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hi 👋 this PR remove the usage of stripLiteralwithin the devonly build plugin .#24491 is probably due to attributes content being wrapped with " so it is considered as literal by stripLiteral

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@huang-julien
Copy link
Member Author

cc @stafyniaksacha

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@e3b8b84). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #24511   +/-   ##
=======================================
  Coverage        ?   58.65%           
=======================================
  Files           ?        5           
  Lines           ?      861           
  Branches        ?       46           
=======================================
  Hits            ?      505           
  Misses          ?      356           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe
Copy link
Member

sorry for the unsolicited change; it's minor - we keep components directory for mode to auto-import components rather than the built-in Nuxt components.

but I will think about reorganising our directory structure as I think it's a bit confusing.

@huang-julien
Copy link
Member Author

ah my bad, i thought it was for plugins related to components 😅

@danielroe danielroe changed the title fix(nuxt): don't strip literals from template in devOnly plugin fix(nuxt): don't strip literals from template in <DevOnly> Nov 28, 2023
@danielroe danielroe merged commit f98aa5d into main Nov 28, 2023
@danielroe danielroe deleted the fix/dev-only-class branch November 28, 2023 21:49
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Merged
TheAlexLichter pushed a commit that referenced this pull request Dec 11, 2023
@huang-julien @TheAlexLichter
fix(nuxt): don't strip literals from template in <DevOnly> (#24511)
c420ca6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.x bug 🔨 p3-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<DevOnly> empties props of elements in its #fallback slot
3 participants
@huang-julien @codecov-commenter @danielroe