Update emoji data #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbrowning thanks for this! As I've seen in the other versions of the libraries there are also some gotchas with new complexities in emoji-land. I'd recommend reviewing: mroth/emoji_data.rb#2 Perhaps there is a solution where we integrate all of these and fix this upstream as well? |
|
You're welcome! I believe I've already resolved the exmoji equivalent of mroth/emoji_data.rb#4 (see 1dfe0e8 & 076982d). Unless I'm missing something, only remaining complexity you're looking to solve there is support for a default skin variant? |
Closed
28b9f49 to
672a570
Compare
One or all of these emoji #⃣ #️⃣ *⃣ were causing:
== Compilation error on file lib/exmoji/scanner.ex ==
** (Regex.CompileError) nothing to repeat at position 5795
(elixir) lib/regex.ex:142: Regex.compile!/2
lib/exmoji/scanner.ex:43: (module)
(stdlib) erl_eval.erl:670: :erl_eval.do_apply/6
The previous "variant" ID is now considered the default and non-qualified values have been moved from "uid" to the new "non_qualified" field. A result of this is that the "variant_encoding" option to EmojiChar.render/2 now defaults to false.
It was taking precedence over the conanical family emoji and rendering as 3 separate emojis instead of the family
082ba06 to
a975fd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a stopgap measure before #7 is resolved, this PR updates the emoji data file to the latest version available from https://github.com/iamcal/emoji-data.