This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Update to latest emoji.json (Unicode 8.0) #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty great. Do you have any thoughts as to the best way to handle integrating #2 with this? |
|
Let me take a look at the other PR a little bit to see how it handles the update to emoji.json, which are significant. I feel like it should be fairly easy to re-base that PR on top of this change, but I'll take a look and verify. |
This was referenced Feb 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the emoji.json file to the latest from iamcal/emoji-data@401f2b4
As part of this, a couple methods in EmojiData.rb had to be updated to handle some quirks in the new emoji set:
nullvaluesOne side effect of doing this update without #2 is that scanning for emoji with skin variants now returns two EmojiChar instances.