Clean up webgpu_compute_cloth example
#31130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webgpu_compute_clothwebgpu_compute_cloth example
|
There is a design problem that will have to be addressed in another PR. The material color set in the GUI does not match the rendered material color. |
|
Instead of: materialFolder.addColor( clothMaterial, 'color' );try it with: materialFolder.addColor( { color: clothMaterial.color.getHex( THREE.SRGBColorSpace ) }, 'color' ).onChange( value => clothMaterial.color.set( value ) );Same for the sheen color. |
That results in rounding problems in my testing. Compare with the approach used by the matcap example. |
Mugen87
approved these changes
May 20, 2025
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the material color so the sheen is readily apparent.