Skip to content

USDZExporter: Fix Object indentation level #31126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2025
Merged

USDZExporter: Fix Object indentation level #31126

merged 1 commit into from
May 18, 2025

Conversation

mkeblx
Copy link
Contributor

@mkeblx mkeblx commented May 17, 2025

Description

Add 3 tabs for Object_x's as they should always be placed at 3 levels in with the current exporter fixed output structure.

Before:

def Xform "Root"
{
	def Scope "Scenes" (
		kind = "sceneLibrary"
	)
	{
		def Xform "Scene" (
			customData = {
				bool preliminary_collidesWithEnvironment = 0
				string sceneName = "Scene"
			}
			sceneName = "Scene"
		)
		{
def Xform "Object_15" (
	prepend references = @./geometries/Geometry_3.usda@</Geometry>
	prepend apiSchemas = ["MaterialBindingAPI"]
)
{
	matrix4d xformOp:transform = ( (1, 0, 0, 0), (0, 1, 0, 0), (0, 0, 1, 0), (0, 0, 0, 1) )
	uniform token[] xformOpOrder = ["xformOp:transform"]

	rel material:binding = </Materials/Material_6>
}
...

After:

def Xform "Root"
{
	def Scope "Scenes" (
		kind = "sceneLibrary"
	)
	{
		def Xform "Scene" (
			customData = {
				bool preliminary_collidesWithEnvironment = 0
				string sceneName = "Scene"
			}
			sceneName = "Scene"
		)
		{
			def Xform "Object_15" (
				prepend references = @./geometries/Geometry_3.usda@</Geometry>
				prepend apiSchemas = ["MaterialBindingAPI"]
			)
			{
				matrix4d xformOp:transform = ( (1, 0, 0, 0), (0, 1, 0, 0), (0, 0, 1, 0), (0, 0, 0, 1) )
				uniform token[] xformOpOrder = ["xformOp:transform"]

				rel material:binding = </Materials/Material_6>
			}
...

@Mugen87 Mugen87 added this to the r177 milestone May 18, 2025
@Mugen87 Mugen87 merged commit b654763 into mrdoob:dev May 18, 2025
11 checks passed
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@mkeblx @RuthySheffi
USDZExporter: Fix Object indentation level (mrdoob#31126)
36154c0
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@mkeblx @RuthySheffi
USDZExporter: Fix Object indentation level (mrdoob#31126)
a81be48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r177
Development

Successfully merging this pull request may close these issues.
2 participants
@mkeblx @Mugen87